Process extensions in packaged tests if they exist

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Fallen, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

3 years ago
Created attachment 8478666 [details] [diff] [review]
Fix - v1

Thunderbird packaged tests contain the Lightning extension, which buildbot copies over into the bin/extensions directory. We need something similar to make calendar tests run with mozharness.

The patch is untested since I don't have a staging environment, but jcranmer wanted to take care of that.
Attachment #8478666 - Flags: review?(jlund)
Attachment #8478666 - Flags: feedback?(Pidgeot18)
Attachment #8478666 - Flags: feedback?(standard8)
Comment on attachment 8478666 [details] [diff] [review]
Fix - v1

Review of attachment 8478666 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/desktop_unittest.py
@@ +397,5 @@
>                            abs_app_plugins_dir,
>                            overwrite='overwrite_if_exists')
> +            if os.path.isdir(dirs['abs_test_extensions_dir']):
> +                self.copytree(dirs['abs_test_extensions_dir'],
> +                              abs_app_extenions_dir,

Typo: missing s...
Created attachment 8479365 [details] [diff] [review]
The fix v2

I took Philipp's patch, ran it through mozharness locally and found a couple of issues.

This patch adds the extensions/ directory to the list of parts of the zip to be unpacked.

It also fixes the directory detection - the extensions directory source is in the "test" directory.

With this, xpcshell tests for a Thunderbird build ran correctly with the lightning extension installed.
Attachment #8479365 - Flags: review?(jlund)
Comment on attachment 8478666 [details] [diff] [review]
Fix - v1

Forgot to obsolete this patch.
Attachment #8478666 - Attachment is obsolete: true
Attachment #8478666 - Flags: review?(jlund)
Attachment #8478666 - Flags: feedback?(standard8)
Attachment #8478666 - Flags: feedback?(Pidgeot18)
Created attachment 8479386 [details] [diff] [review]
The fix v2a

Correct patch this time.
Attachment #8479365 - Attachment is obsolete: true
Attachment #8479365 - Flags: review?(jlund)
Attachment #8479386 - Flags: review?(jlund)
Comment on attachment 8479386 [details] [diff] [review]
The fix v2a

Review of attachment 8479386 [details] [diff] [review]:
-----------------------------------------------------------------

first, sorry for delay; I've been on PTO

hmm, so firefox will not have an extensions dir in the tests zip right?

which means I think we will log the following on every one of our unittest test jobs (aside from thunderbird):
    caution: filename not matched:  extensions

I think that's OK but it is noisy and the configs suggest firefox should have it. could we put a custom 'minimum_tests_zip_dirs' in: http://mxr.mozilla.org/build/source/mozharness/configs/unittests/thunderbird_extra.py instead? Assuming we call that config after say unittests/linux_unittest.py, it will override the anything in linux_unittest.py.

r- to clear my queue. feel free to fight back for an r+ if you do not agree with me :)
Attachment #8479386 - Flags: review?(jlund) → review-
Created attachment 8480435 [details] [diff] [review]
The fix v3

Yep, using the Thunderbird specific config file seems the better way to go.
Assignee: philipp → standard8
Attachment #8479386 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8480435 - Flags: review?(jlund)
Comment on attachment 8480435 [details] [diff] [review]
The fix v3

lgtm :)
Attachment #8480435 - Flags: review?(jlund) → review+
Comment on attachment 8480435 [details] [diff] [review]
The fix v3

https://hg.mozilla.org/build/mozharness/rev/461eb9ef2e34
Attachment #8480435 - Flags: checked-in+
patch(es) in production :)
Confirmed working.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.