1058297 - Allow opting-out of "build complete" spam

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Matthew Gregan [:kinetik]]

There should be a way to opt-out of notification spam from the build system.  Here's a trivial patch to do so via a MOZ_NOSPAM environment variable.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: bug1058297_v0.patch

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8478669 [details] [diff] [review]
bug1058297_v0.patch

Review of attachment 8478669 [details] [diff] [review]:
-----------------------------------------------------------------

Another feature that could be solved with mach config files instead of undocumented environment variables. But that's not your problem.

::: python/mozbuild/mozbuild/mach_commands.py
@@ +401,4 @@
>                  self.log(logging.INFO, 'ccache',
>                           {'msg': ccache_diff.hit_rate_message()}, "{msg}")
>  
> +        moz_nospam = os.getenv('MOZ_NOSPAM')

This should be os.environ.get('MOZ_NOSPAM')

The reason is os.environ does extra magic around environment variables and it's preferred to go through it.

Comment 3

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e73004b33f2

Comment 4

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/mozilla-central/rev/0e73004b33f2