Closed Bug 1058297 Opened 5 years ago Closed 5 years ago

Allow opting-out of "build complete" spam

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: kinetik, Unassigned)

Details

Attachments

(1 file)

There should be a way to opt-out of notification spam from the build system.  Here's a trivial patch to do so via a MOZ_NOSPAM environment variable.
Attachment #8478669 - Flags: review?(gps)
Comment on attachment 8478669 [details] [diff] [review]
bug1058297_v0.patch

Review of attachment 8478669 [details] [diff] [review]:
-----------------------------------------------------------------

Another feature that could be solved with mach config files instead of undocumented environment variables. But that's not your problem.

::: python/mozbuild/mozbuild/mach_commands.py
@@ +401,4 @@
>                  self.log(logging.INFO, 'ccache',
>                           {'msg': ccache_diff.hit_rate_message()}, "{msg}")
>  
> +        moz_nospam = os.getenv('MOZ_NOSPAM')

This should be os.environ.get('MOZ_NOSPAM')

The reason is os.environ does extra magic around environment variables and it's preferred to go through it.
Attachment #8478669 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/0e73004b33f2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.