1058428 - MediaSourceReader::DecodersContainTime is busted

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

MediaSourceReader::Seek waits for the subdecoders to have data in the range it wants to seek into.  This is tested via DecodersContainTime, but that will return true even if only one of the subdecoders contain the target range.  If we have separate audio and video subdecoders and only one is ready, the WaitForData loop in Seek will exit early and seeking will fail.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Ensure all in-use decoders contain the target range

Bug 1058428 - Ensure all decoders contain target range

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8479532 [details] [diff] [review]
Ensure all in-use decoders contain the target range

Review of attachment 8479532 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/mediasource/MediaSourceReader.cpp
@@ +403,2 @@
>    for (uint32_t i = 0; i < mDecoders.Length(); ++i) {
> +    if (!mDecoders[i]->IsDiscarded()) {

This is not correct, because these decoders may still be contributing frames to the "track buffer".  IsDiscarded tells us that we can't expect more data to be added to this decoder via SB::AppendBuffer, but we can still use the data that this decoder already has (and we are reporting is present via SB::GetBuffered).

Comment 3

[cajbir (:cajbir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36da0216faed

Comment 4

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #2)
> This is not correct, because these decoders may still be contributing frames
> to the "track buffer".  IsDiscarded tells us that we can't expect more data
> to be added to this decoder via SB::AppendBuffer, but we can still use the
> data that this decoder already has (and we are reporting is present via
> SB::GetBuffered).

Filed bug 1059058 to handle this.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/36da0216faed