Closed Bug 1058436 Opened 5 years ago Closed 5 years ago

Safe Mode: Use "safe" xulstore

Categories

(Toolkit :: Startup and Profile System, defect, major)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(1 file)

So that the safe mode dialog can remove the normal xulstore if necessary.
Attached patch Proposed patchSplinter Review
Better still, don't try to load or store anything in safe mode. (I don't know why this approach wasn't used for localstore which ironically was automatically switched to an in-memory data source during shutdown, unlike xulstore which just ignores writes.)

I renamed init to load to make it clearer what's going on there. I conflated needsSaving and writeTimerInitialized as they have the same value. This allowed me to remove the now unnecessary callback function.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8479800 - Flags: review?(enndeakin)
Attachment #8479800 - Flags: review?(enndeakin) → review+
https://hg.mozilla.org/mozilla-central/rev/7ed7216d3d8b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.