"is.gd Creator (fork)" add-on does not work with e10s

RESOLVED FIXED

Status

()

Firefox
Extension Compatibility
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpeterson, Unassigned)

Tracking

({addon-compat})

unspecified
x86
Mac OS X
addon-compat
Points:
---

Firefox Tracking Flags

(e10s+)

Details

(Reporter)

Description

3 years ago
When I click the "is.gd Creator" toolbar button to create a short URL using http://is.gd/ nothing happens, but I see the following error message in Firefox's Browser Console:

> TypeError: IsGdCreator.focused.value is undefined. isgd.js:153

Here is the failing function from the add-on JS:

    isURLSelected: function() {
        if (IsGdCreator.focused!=null) {
            var sel=IsGdCreator.focused.value.substring(IsGdCreator.focused.selectionStart,IsGdCreator.focused.selectionEnd);
            return IsGdCreator.isValidURL(sel);
        }
        return false;
    },
(Reporter)

Comment 1

3 years ago
https://addons.mozilla.org/en-US/firefox/addon/isgd-creator-fork/
Summary: "is.gd Creator" add-on does not work with e10s → "is.gd Creator (fork)" add-on does not work with e10s
(Reporter)

Comment 2

3 years ago
hi mrkschan, if you have any questions about add-on support for multiprocess Firefox (e10s), just drop by the #e10s IRC channel on irc.mozilla.org. MDN also has a good introduction:

https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

Comment 3

3 years ago
Hey :cpeterson, I'm considering to port the extension from XUL to use High-Level APIs of the SDK, is there any tools out there that can help the migration?
(Reporter)

Comment 4

3 years ago
Unfortunately, I don't think there are any tools to automate the porting of extensions from XUL to the Add-on SDK. The good news is that I don't think you need to rewrite much code. The is.gd toolbar is operable. You probably just need to write a frame script to grab the current page's URL from the sandboxed content process.

Comment 5

3 years ago
Hey :cpeterson, where can i find docs talking about the backward compatibility of frame script?
(Reporter)

Comment 6

3 years ago
mrkschan: this MDN page is a good tutorial for making an existing extension compatible with e10s using frame scripts:

https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

Drop by the #e10s IRC channel on irc.mozilla.org if you have more technical questions.

Comment 7

3 years ago
Hey :cpeterson, I rewrote the thing using Add-on SDK. I think it will be e10s compatible. Ref - https://addons.mozilla.org/en-US/firefox/addon/isgd-creator-fork/versions/
(Reporter)

Comment 8

3 years ago
Thanks! I just tested version 0.3 and it works for me with e10s. I use this add-on all the time. :)

I'd like to keep this bug report open until version 0.3 completes the addons.mozilla.org review process and becomes the default version. That will avoid user confusion where this bug report is marked fixed (which automatically updates the list of compatible add-ons on arewee10syet.com), but the default version (0.2.4) is not e10s-compatible yet.

When version 0.3 is your new default version, please feel free to close this bug or ping me.
Approved.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.