Closed Bug 1058451 Opened 10 years ago Closed 10 years ago

Intermittent test_CSP_bug885433.html | Inline script should be allowed - Result logged after SimpleTest.finish()

Categories

(Core :: Security, defect)

Product:
Core
Component:
Security
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34
Tracking Flags:
Tracking Status
firefox32 --- wontfix
firefox33 --- fixed
firefox34 --- fixed
firefox-esr24 --- wontfix
firefox-esr31 --- wontfix

People

(Reporter: cbook, Assigned: martijn.martijn)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

1058451.diff (for check-in)
2.10 KB, patch
geekboy
: review+
Details | Diff | Splinter Review 
Android 2.3 Emulator mozilla-inbound opt test mochitest-1 on 2014-08-25 18:08:33 PDT for push 0843c26857a9

slave: tst-linux64-spot-912

https://tbpl.mozilla.org/php/getParsedLog.php?id=46736208&tree=Mozilla-Inbound



31 INFO TEST-UNEXPECTED-FAIL | /tests/content/base/test/csp/test_CSP_bug885433.html | Inline script should be allowed - Result logged after SimpleTest.finish()
This should fix it. This makes sure that the load call for checkBlocked is always called before the load call for checkAllowed.
Attachment #8479104 - Flags: review?(garrett.f.robinson+mozilla)
Assignee: nobody → martijn.martijn
Attachment #8479104 - Flags: review?(sstamm)
Comment on attachment 8479104 [details] [diff] [review]
1058451.diff (for check-in)

Review of attachment 8479104 [details] [diff] [review]:
-----------------------------------------------------------------

> This should fix it. This makes sure that the load call for checkBlocked 
> is always called before the load call for checkAllowed.

I think it's the other way around: checkAllowed runs and doesn't start the "blocked" test until after the first test completes.  Regardless, this serializes the two tests and doesn't call SimpleTest.finish() until after both run (in checkBlocked).  Thanks for the fix.

Garrett: I'm clearing your review flag because this is a pretty simple patch and I don't think it requires double-checking.  Feel free to take a look, though, if you want.
Attachment #8479104 - Flags: review?(sstamm)
Attachment #8479104 - Flags: review?(garrett.f.robinson+mozilla)
Attachment #8479104 - Flags: review+
(In reply to Sid Stamm [:geekboy or :sstamm] from comment #6)
> > This should fix it. This makes sure that the load call for checkBlocked 
> > is always called before the load call for checkAllowed.
> 
> I think it's the other way around: checkAllowed runs and doesn't start the

Yeah, sorry, I mixed it up.
Keywords: checkin-needed
Attachment #8479104 - Attachment description: 1058451.diff → 1058451.diff (for check-in)
https://hg.mozilla.org/mozilla-central/rev/c16359660b11
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: