[v2.1] Remove setting permission for geolocation from setUp

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: RobertC, Assigned: RobertC)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

4 years ago
Due to the changes in Bug 1058319, certified apps no longer prompt for geolocation permissions.

Tests need to be updated so that they no longer try to set the permission to deny, because that throws an error:
JavaScript Error: "PermissionSettings.js: 'geolocation' is an implicit permission for 'app://collection.gaiamobile.org/manifest.webapp' or the permission isn't set"

First inbound build in which this issue was detected:
http://jenkins1.qa.scl3.mozilla.com/job/flame.b2g-inbound.ui.functional.smoke/1018/HTML_Report/

Build info v2.1 flame:
Device firmware (date) 	27 Jun 2014 00:57:58
Device firmware (incremental) 	110
Device firmware (release) 	4.3
Device identifier 	flame
Gaia date 	25 Aug 2014 16:45:10
Gaia revision 	38abafd2b7a6
Gecko build 	20140825172952
Gecko revision 	883564cbc9a3
Gecko version 	34.0a1
(Assignee)

Comment 1

4 years ago
Created attachment 8478919 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23314

Fabrice, is the error from comment 0 to be expected when trying to set geolocation permission for a certified app?
Attachment #8478919 - Flags: review?(viorela.ioia)
Attachment #8478919 - Flags: review?(florin.strugariu)
Flags: needinfo?(fabrice)
(Assignee)

Comment 2

4 years ago
The changes from Bug 1058319 have been reverted in https://hg.mozilla.org/integration/b2g-inbound/c50194d57e6d.

For now this bug should remain on stand by and see what happens next.
(In reply to Robert Chira [:RobertC] from comment #1)
> Created attachment 8478919 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23314
> 
> Fabrice, is the error from comment 0 to be expected when trying to set
> geolocation permission for a certified app?

No, geolocation should not turn into an implicit permission. I'll fix that when relanding in bug 1058319
Flags: needinfo?(fabrice)
Attachment #8478919 - Flags: review?(viorela.ioia)
Comment on attachment 8478919 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23314

Looks like there is no need for this as :fabrice will update this
Attachment #8478919 - Attachment is obsolete: true
Attachment #8478919 - Flags: review?(florin.strugariu)
The issue has been fixed in Bug 1058319. Closing this bug
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.