1058530 - "Yahoo! Toolbar" add-on does not work with e10s

Status: RESOLVED INCOMPLETE

(Firefox :: Extension Compatibility, defect)

Description

[iamjayakumars]

Attachment: Screen_Shot_2014-08-26_at_16_32_07.jpg

Can able to install, but the options and setting are not displaying.

Mentioned in Screenshot.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

The developer has been contacted through AMO.

Comment 2

[Chris Peterson [:cpeterson]]

I can reproduce this in Nightly 37. When I try to open the toolbar's preferences (in about:addons), I only see a white square on screen and the following error message in the browser console:

NS_NOINTERFACE: Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface] nsYahooToolbarManager.js:237:0

from this code in nsYahooToolbarManager.js:

>                 if (topic == "cookie-changed") {                   // List cleared
>                    if (subject != null) {
>                       yahooUtils.setTimeout(function () {
>                          var cookie = subject.QueryInterface(Components.interfaces.nsICookie);
>                          ...

Comment 3

[Allison Naaktgeboren :ally]

Telemetry is reporting that this addon is regularly throwing exceptions not associated with any file (FILE_NOT_FOUND). This might mean that there is a problem loading a file.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Assignee: Bill McCloskey
Link to add-on: https://us.toolbar.yahoo.com/
Contact info for add-on: AMO
Add-on ID: {635abd67-4fe9-1b23-4f01-e679fa7484c1}
How well does it work?: 40%
Steps to reproduce working features:
- searching from the search box works
- search suggestions broken in both e10s and non-e10s
- clicking on existing toolbar buttons works
- RSS feeds seem to be detected based on the page. An RSS icon is shown over the "+" button.

Steps to reproduce broken features:
- Clicking on the "gear" icon and selecting "Edit Toolbar" or "Edit Settings" produces a blank tab.
- Clicking on "Preferences" from about:addons produces a blank tab.
- Clicking "+" and "Add this page to toolbar" is does nothing. Should add an entry to the toolbar.
- Clicking "+" and "Select from button gallery" produces blank tab. Should show list of widgets.

Any obvious performance problems? no

Chromium version: https://chrome.google.com/webstore/detail/yahoo-extension/eihhgekonheiliaidomffpplfhecmkag?hl=en

It doesn't seem to do very much. It changes the new tab page but doesn't show any kind of toolbar. Apparently there used to be a version that added a toolbar to every page via a content script. But Google forced them to remove that:
http://blog.chromium.org/2013/12/keeping-chrome-extensions-simple.html

Comment 5

[Jerod Lycett]

It's not working in Aurora regardless of e10s.

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Let's try to find someone to talk to at Yahoo.

Comment 7

[Sylvain Giroux [:Spoji]]

(In reply to Bill McCloskey (:billm) from comment #6)
> Let's try to find someone to talk to at Yahoo.

I have worked in the past with Yahoo for their Toolbar on IE & Firefox. If contacts are still needed, I can provide you with some.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

We have been talking to the Yahoo! team about the toolbar, and they were working on a new codebase, but that work was put on hold a while ago. Since now we have a clearer e10s timeline, I'll restart the conversation with them.

Comment 9

[Karl Dubost💡 :karlcow]

(In reply to Jorge Villalobos [:jorgev] from comment #8)
> We have been talking to the Yahoo! team about the toolbar, and they were
> working on a new codebase, but that work was put on hold a while ago. Since
> now we have a clearer e10s timeline, I'll restart the conversation with them.

Any status about this?

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

I haven't heard back from them.

Comment 11

[Karl Dubost💡 :karlcow]

Jorge, what is your plan? Will you recontact them?

Comment 12

[Jorge Villalobos [:jorgev] (he/him)]

I did get a response from them a while ago, and they are aware the add-on isn't compatible with e10s. I don't know if they'll have a compatible version by the time we enable it for all beta users, but we will mark it as incompatible if they don't.

Comment 13

[Kev Needham [:kev]]

Adding Mike Kaply, I believe Yahoo is addressing, but has requested a release date for e10s.

Comment 14

[Mike Kaply (PTO until 9/30) [:mkaply]]

> Adding Mike Kaply, I believe Yahoo is addressing, but has requested a release date for e10s.

Yahoo is working on a completely new extension for e10s, so this bug will probably go away.

And yes, they would really like to know which release e10s is going to actually go into. I don't think we even know, do we?

Comment 15

[Firefox Bug Husbandry Bot]

With Firefox 57 only WebExtensions are permitted and are, by default, e10s compatible.