1058585 - [B2G][RIL][Flame] fail to switch default data connection

Status: VERIFIED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

STR:
1). Enable data connection (default data is sim 1)
2). Go to Setting->Sim Manager
3). Switch data connection to sim 2

Expected:
Device can establish data connection on sim 2

Actual:
Device doeesn't establish data connection on sim 2

Comment 1

[Edgar Chen [:edgar]]

When switching default data connection, we process data registration request one by one, but in flame we don't really send a request to rild for deactivating, so device gets stuck on waiting the response of deactivating request.

Comment 2

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 3

[Edgar Chen [:edgar]]

Attachment: Patch, v2

Comment 4

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> When switching default data connection, we process data registration request
> one by one, but in flame we don't really send a request to rild for
> deactivating, so device gets stuck on waiting the response of deactivating
> request.

Good catch :D

Comment 5

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

[Blocking Requested - why for this release]: regression on a basic feature

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8479786 [details] [diff] [review]
Patch, v2

Hi Hsinyi, could you help to review this? Thank you.

Comment 7

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 8479786 [details] [diff] [review]
Patch, v2

Review of attachment 8479786 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!

Comment 8

[Edgar Chen [:edgar]]

Thanks for the review, Hsinyi.

https://hg.mozilla.org/integration/b2g-inbound/rev/b817a5217c83

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b817a5217c83

Comment 10

[Eric Chang [:ericcc] [:echang]]

Verified okay
Gaia-Rev        778ebac47554e1c4b7e9a952d73e850f58123914
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/aa98eb8873a2
Build-ID        20141005160206
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141005.194124
FW-Date         Sun Oct  5 19:41:35 EDT 2014
Bootloader      L1TC00011840