1058597 - [DeviceStorage] Linux test_ipc.html failure with dom/devicestorage/test/test_dirs.html

Status: RESOLVED INCOMPLETE

(Core :: DOM: Device Interfaces, defect)

Description

[Andrew Halberstadt [:ahal]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=46738917&tree=Try&full=1

Bug 1057558 fixes a problem where failed assertions in ipc tests weren't causing the job to fail. At this point it's unclear if this was a regression, or if it was never working properly in the first place.

Either way, fixing it uncovered a failure in dom/devicestorage/test/test_dirs.html. We either need to fix this test asap, or temporarily disable the ipc devicestorage tests so we can land bug 1057558.

Comment 1

[Dave Hylands [:dhylands]]

What's failing?

All I can see is:

19:03:13     INFO -  3359 INFO TEST-UNEXPECTED-FAIL | /tests/dom/devicestorage/ipc/test_ipc.html | /tests/dom/devicestorage/test/test_dirs.html
19:03:13     INFO -  3360 INFO TEST-UNEXPECTED-FAIL | /tests/dom/devicestorage/ipc/test_ipc.html | /tests/dom/devicestorage/test/test_dirs.html
19:03:13     INFO -  3361 INFO TEST-UNEXPECTED-FAIL | /tests/dom/devicestorage/ipc/test_ipc.html | /tests/dom/devicestorage/test/test_dirs.html

Comment 2

[Ahmed Kachkach [:akachkach]]

@dhylands:

Just posted an alternate patch in bug 1057558, it should give better error logs.

Comment 3

[Dave Hylands [:dhylands]]

test_dirs looks pretty straightforward to me, except for some special powers stuff.

Maybe this is a manifest problem?

Looking at testing/mochitest/manifest.webapp I only see pictures and sdcard listed. And not videos, music, apps, or crashes. 

http://dxr.mozilla.org/mozilla-central/source/dom/apps/src/PermissionsTable.jsm?from=PermissionsTable.jsm#66

Comment 4

[Dave Hylands [:dhylands]]

And I believe that gaia/dev_apps/mochitest/manifest.webapp is used when gaia is in the picture.

Comment 5

[Dave Hylands [:dhylands]]

And only apps needs webapps-manage

sdcard and crashes are just additional types like pictures, music, and videos.

Comment 6

[Ahmed Kachkach [:akachkach]]

Try run here (with the modified patch) : https://tbpl.mozilla.org/?tree=Try&rev=c9cde5f117a2

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Cleaning up Device Interfaces component, and mass-marking old FxOS bugs as incomplete.

If any of these bugs are still valid, please let me know.