Closed
Bug 1058676
Opened 10 years ago
Closed 10 years ago
Remove treeherder-ui docs dependency on sphinxcontrib-httpdomain
Categories
(Tree Management :: Treeherder, defect, P4)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
Details
Attachments
(1 file)
|
1.01 KB,
patch
|
Details | Diff | Splinter Review |
Mauro thought that (unlike treeherder-service) the treeherder-ui docs conf.py might not need the sphinxcontrib-httpdomain extension after all, and as such we could remove it from both conf.py and the requirements file.
If that were the case, we could then switch off "use virtualenv" mode on readthedocs, which will simplify docs generation.
Cameron, are we (or will we be in the future) using sphinxcontrib-httpdomain in treeherder-ui docs at all? :-)
Flags: needinfo?(cdawson)
|
||
Comment 1•10 years ago
|
||
Ed-- Feel free to remove that. I don't think we use that in the UI. If we ever do, we can add it back in at that time.
Flags: needinfo?(cdawson)
|
Assignee | |
Comment 2•10 years ago
|
||
Assignee: nobody → emorley
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://github.com/mozilla/treeherder-ui/commit/1f4b7613181fc72a54ae0816f6f0d70071ea4ae5
Have adjusted the RTD prefs for treeherder-ui to not use a virtualenv/the requirements file - build succeeds.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Priority: -- → P4
Resolution: --- → FIXED
|
||
Comment 4•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/7a9a1c701086afc217c64229cf4bc2625e4117bc
Bug 1058676 - docs: Remove dependency on unused sphinxcontrib-httpdomain
You need to log in
before you can comment on or make changes to this bug.
Description
•