Closed
Bug 1058766
Opened 10 years ago
Closed 10 years ago
Include window count for each application
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: m_and_m, Assigned: m_and_m)
References
Details
Attachments
(1 file)
12.71 KB,
patch
|
jesup
:
review+
florian
:
feedback+
|
Details | Diff | Splinter Review |
The application capture engine should provide the window count for each application, for display to the user when selecting which to share.
Updated•10 years ago
|
Depends on: appsharing
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → linuxwolf
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8479419 [details] [diff] [review]
Include window count for each application
This patch uses "\x1e" (Record Separator) to separate the window count from the application name; Some examples:
* "2\x1eFinder"
* "1\x1eSublime Text"
* "3\x1eTerminal"
* "0\x1eVMWare Fusion"
This should be enough to name.split("\x1e") in JavaScript.
Attachment #8479419 -
Flags: review?(rjesup)
Attachment #8479419 -
Flags: feedback?(florian)
Comment 3•10 years ago
|
||
Comment on attachment 8479419 [details] [diff] [review]
Include window count for each application
Review of attachment 8479419 [details] [diff] [review]:
-----------------------------------------------------------------
::: media/webrtc/trunk/webrtc/modules/desktop_capture/win/desktop_device_info_win.cc
@@ +53,5 @@
> void DesktopDeviceInfoWin::InitializeApplicationList() {
> // List all running applications exclude background process.
> HWND hWnd;
> for (hWnd = GetWindow(GetDesktopWindow(), GW_CHILD); hWnd; hWnd = GetWindow(hWnd, GW_HWNDNEXT)) {
> + if (!IsWindowVisible(hWnd))
trailing space. Also, since you're touching it, {} around continue
Attachment #8479419 -
Flags: review?(rjesup) → review+
Updated•10 years ago
|
Blocks: 1059220, appsharing
No longer depends on: appsharing
Comment 4•10 years ago
|
||
Comment on attachment 8479419 [details] [diff] [review]
Include window count for each application
Works for me (tested only on Mac), thanks! I attached the UI changes that need to land at the same time in bug 1059220.
Attachment #8479419 -
Flags: feedback?(florian) → feedback+
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•