Closed Bug 1058886 Opened 10 years ago Closed 10 years ago

Make gtest code look better after multi-framemetrics changes

Categories

(Core :: Panning and Zooming, defect)

Product:
Core
Component:
Panning and Zooming
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35
Tracking Flags:
Tracking Status
firefox33 --- wontfix
firefox34 --- fixed
firefox35 --- fixed
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Add an ApzcOf helper
17.62 KB, patch
botond
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
The part 10a patch from bug 1055760 makes the code in TestAsyncPanZoomController pretty ugly. Filing this bug to clean it up, since it'll take some time to come up with something elegant, and I don't want to hold up landing bug 1055760 just for this.
Assignee: nobody → bugmail.mozilla
Attachment #8484294 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/07d1e106d250
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment on attachment 8484294 [details] [diff] [review]
Add an ApzcOf helper

Approval Request Comment
[Feature/regressing bug #]: bug 1055760
[User impact if declined]: no direct impact; however future fixes to the multi-layer-apz feature that need uplifting to 2.0 will likely depend on this to apply cleanly, so it would be nice to uplift
[Describe test coverage new/current, TBPL]: landed on master, the tests are exercised and pass
[Risks and why]: extremely low risk; simple refactoring in test-only code.
[String/UUID change made/needed]: none
Attachment #8484294 - Flags: approval-mozilla-aurora?
Depends on: 1063847
Attachment #8484294 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [please uplift 1063847 along with this; a=test-only]
https://hg.mozilla.org/releases/mozilla-aurora/rev/5a319373ef01
status-b2g-v2.1: --- → fixed
status-b2g-v2.2: --- → fixed
status-firefox33: --- → wontfix
status-firefox34: --- → fixed
status-firefox35: --- → fixed
Whiteboard: [please uplift 1063847 along with this; a=test-only]
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: