1058886 - Make gtest code look better after multi-framemetrics changes

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

The part 10a patch from bug 1055760 makes the code in TestAsyncPanZoomController pretty ugly. Filing this bug to clean it up, since it'll take some time to come up with something elegant, and I don't want to hold up landing bug 1055760 just for this.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Add an ApzcOf helper

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=2f47230f374c

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/07d1e106d250

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/07d1e106d250

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8484294 [details] [diff] [review]
Add an ApzcOf helper

Approval Request Comment
[Feature/regressing bug #]: bug 1055760
[User impact if declined]: no direct impact; however future fixes to the multi-layer-apz feature that need uplifting to 2.0 will likely depend on this to apply cleanly, so it would be nice to uplift
[Describe test coverage new/current, TBPL]: landed on master, the tests are exercised and pass
[Risks and why]: extremely low risk; simple refactoring in test-only code.
[String/UUID change made/needed]: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5a319373ef01