1058893 - nsFocusManager needs to cycle collect more fields

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight (out until 2026) [:mccr8]]

In bug 1054089, there's a div element with a missing edge in it, and some kind of focusy-stuff seems to be getting run on it, so I looked at nsFocusManager.  While this class is cycle collected, the fields mDelayedBlurFocusEvents and mMouseButtonEventHandlingDocument are not cycle collected, but they can hold cycle collected things, so I think they should be.

Comment 1

[Andrew McCreight (out until 2026) [:mccr8]]

Though I suppose since there is exactly one focus manager, it is legitimately alive in bug 1054089, so traversing more stuff won't fix a leak, even if it is the issue. But at least we'd see why it was actually alive.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Yeah, focusmanager is a service so CCing it isn't that important, except for getting better logs.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: CC remaining nsFocusManager fields (teach the CC to traverse a nsDelayedBlurOrFocusEvent)

Comment 4

[Andrew McCreight (out until 2026) [:mccr8]]

Comment on attachment 8483031 [details] [diff] [review]
CC remaining nsFocusManager fields (teach the CC to traverse a nsDelayedBlurOrFocusEvent)

Review of attachment 8483031 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ade22981285b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ade22981285b