Closed Bug 1058893 Opened 7 years ago Closed 7 years ago

nsFocusManager needs to cycle collect more fields

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: mccr8, Assigned: bjacob)

References

Details

Attachments

(1 file)

In bug 1054089, there's a div element with a missing edge in it, and some kind of focusy-stuff seems to be getting run on it, so I looked at nsFocusManager.  While this class is cycle collected, the fields mDelayedBlurFocusEvents and mMouseButtonEventHandlingDocument are not cycle collected, but they can hold cycle collected things, so I think they should be.
Summary: nsFocusManager needs to cycle collector more fields → nsFocusManager needs to cycle collect more fields
Though I suppose since there is exactly one focus manager, it is legitimately alive in bug 1054089, so traversing more stuff won't fix a leak, even if it is the issue. But at least we'd see why it was actually alive.
Yeah, focusmanager is a service so CCing it isn't that important, except for getting better logs.
Assignee: nobody → bjacob
Comment on attachment 8483031 [details] [diff] [review]
CC remaining nsFocusManager fields (teach the CC to traverse a nsDelayedBlurOrFocusEvent)

Review of attachment 8483031 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8483031 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/ade22981285b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.