Closed
Bug 1058916
Opened 10 years ago
Closed 5 years ago
Cycle collect more fields of TabChild
Categories
(Core :: DOM: Content Processes, defect)
Core
DOM: Content Processes
Tracking
()
RESOLVED
DUPLICATE
of bug 1401379
People
(Reporter: mccr8, Assigned: mccr8)
Details
(Whiteboard: [MemShrink:P3])
Attachments
(1 file)
|
2.69 KB,
patch
|
Details | Diff | Splinter Review |
TabChild inherits from TabChildBase and TabContext. It CCs fields from the former, but not the latter. Specifically, TabContext has the fields mOwnApp and mContainingApp, which have type nsCOMPtr<mozIApplication>. mozIApplication seems to only be implemented in JS, so I could imagine it leaking all kinds of things.
|
Assignee | |
Comment 1•10 years ago
|
||
I think this isn't quite right, because I'm getting some QI assertion failures.
|
||
Updated•10 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P3]
|
|
Assignee | |
Comment 2•10 years ago
|
||
In addition to the fields it inherits from TabContext, TabChild has a few fields of its own that look like they should maybe be cycle collected, mWebNav and mManager.
Summary: TabChild probably needs to cycle collect fields from TabContext → Cycle collect more fields of TabChild
|
|
Assignee | |
Comment 3•5 years ago
|
||
At least some of this got improved in bug 1401379, so I'll dupe it there. Hooray!
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•