1059031 - Do quartz native drawing in device space when we need a temporary surface

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: quartz-native-drawing-device-space

This fixes some reftest issues.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8479521 [details] [diff] [review]
quartz-native-drawing-device-space

Review of attachment 8479521 [details] [diff] [review]:
-----------------------------------------------------------------

Overall this seems pretty reasonable.

::: gfx/thebes/gfxQuartzNativeDrawing.cpp
@@ +36,5 @@
> +    mNativeRect.RoundOut();
> +
> +    // Quartz theme drawing often adjusts drawing rects, so make
> +    // sure our surface is big enough for that.
> +    mNativeRect.Inflate(5);

I don't understand this comment. What does adjust drawing rects mean? Where does 5 come from?

Comment 2

[Matt Woodrow (:mattwoodrow)]

DrawCellWithSnapping (in nsNativeThemeCocoa.mm) snaps the drawing rect, and that can result in us drawing outside of what we thought the bounds were. The 5 is just a guess of how much margin we need to handle that.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7cf240d88642