Closed Bug 1059031 Opened 6 years ago Closed 6 years ago

Do quartz native drawing in device space when we need a temporary surface

Categories

(Core :: Graphics, defect)

29 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

This fixes some reftest issues.
Attachment #8479521 - Flags: review?(jmuizelaar)
Comment on attachment 8479521 [details] [diff] [review]
quartz-native-drawing-device-space

Review of attachment 8479521 [details] [diff] [review]:
-----------------------------------------------------------------

Overall this seems pretty reasonable.

::: gfx/thebes/gfxQuartzNativeDrawing.cpp
@@ +36,5 @@
> +    mNativeRect.RoundOut();
> +
> +    // Quartz theme drawing often adjusts drawing rects, so make
> +    // sure our surface is big enough for that.
> +    mNativeRect.Inflate(5);

I don't understand this comment. What does adjust drawing rects mean? Where does 5 come from?
Attachment #8479521 - Flags: review?(jmuizelaar) → review+
DrawCellWithSnapping (in nsNativeThemeCocoa.mm) snaps the drawing rect, and that can result in us drawing outside of what we thought the bounds were. The 5 is just a guess of how much margin we need to handle that.
https://hg.mozilla.org/mozilla-central/rev/7cf240d88642
Assignee: nobody → matt.woodrow
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Target Milestone: mozilla35 → mozilla34
You need to log in before you can comment on or make changes to this bug.