1059053 - [Messages][SMS] Icon in Message report is truncated

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: MessageReport.png

[Blocking Requested - why for this release]:

### STR 
1. Send an SMS out
2. Check messages report


### Actual
Truncated icons
MessageReport.png

### Expected
Icon shown without truncation

### 
https://github.com/mozilla-b2g/gaia/tree/master/apps/sms/style/images/icons
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/images/icons/report_delivered.png
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/images/icons/report_delivered%401.5x.png
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/images/icons/report_delivered%402x.png
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/images/icons/report_delivered%402.25x.png

https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/images/icons/report_exclamation.png
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/images/icons/report_exclamation%401.5x.png
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/images/icons/report_exclamation%402x.png
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/images/icons/report_exclamation%402.25x.png
### Version
Gaia      ea93363a8c424d65a9ad91438ce6961377a20f98
Gecko     https://hg.mozilla.org/mozilla-central/rev/f9bfe115fee5
BuildID   20140826160204
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 1

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]: To complete the visual refresh bug

Comment 2

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 8483321 [details] [review]
patch in github

Quick fix and working as expected. Thanks Paco!

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: block for it's obvious UI flaw

Comment 5

[Paco Rampas [:paco]]

Landed: 1950857c5b70fa554fa8e429badb8cd1b722395f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Note that due to recent policy changes, all patches need approval for uplift regardless of blocking status. Please request Gaia v2.1 approval on this patch when you get a chance. Sorry for the inconvenience :(

Comment 7

[Paco Rampas [:paco]]

Comment on attachment 8483321 [details] [review]
patch in github

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): UI changes
[User impact] if declined: incorrect UI
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/174466cca0c61187bc1d64c6b48005ed75e6ce1c

Comment 9

[Eric Chang [:ericcc] [:echang]]

Gaia-Rev        b542080231bb9cdbdb282ab926965ad3f91f7460
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/d614ae398c03
Build-ID        20140923155123
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  27
FW-Date         Thu Sep  4 14:59:02 CST 2014
Bootloader      L1TC10011800

Comment 10

[[:RJ]]

Issue is verified fixed on the 2.2 flame and 2.1 flame 

the SMS Icon in Message report is no longer truncated

Flame 2.2

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141017040208
Gaia: abef62c0623e5504a97b4fd411e879a67b285b52
Gecko: ae1dfa192faf
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 36.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.1

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141017001201
Gaia: 1ea74943cfe525c76a074ca1d7de8e51a70f6b98
Gecko: 2befa902ff5c
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Issue is still occurring on flame 2.0 flame, this was noted in the tracking flags as not fixed though

SMS logo is still truncated 

Flame 2.0

Device: Flame 2.0 KK (319mb) (Full Flash)
BuildID: 20141017000203
Gaia: 9c7dec14e058efef81f2267b724dad0850fc07e4
Gecko: c17df9fe087d
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 11

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding verifyme for 2.0 verification once the fix has been uplifted. If this issue will not be fixed on 2.0 please remove the verifyme tag.

Comment 12

[Julien Wajsberg [:julienw]]

Eric, what do you think? Should we try to uplift to v2.0?

Comment 13

[Eric Chang [:ericcc] [:echang]]

(In reply to Julien Wajsberg [:julienw] from comment #12)
> Eric, what do you think? Should we try to uplift to v2.0?
Always glad to see a better ui on FxOS.

Comment 14

[Julien Wajsberg [:julienw]]

Comment on attachment 8483321 [details] [review]
patch in github

Let's see what triage thinks.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Visual Refresh in v2.0
[User impact] if declined: the icon is "cut" in its borders
[Testing completed]: not in v2.0 yet
[Risk to taking this patch] (and alternatives if risky): low, only low-risk CSS is added on an existing rule
[String changes made]: none

Comment 15

[bhavana bajaj [:bajaj]]

Comment on attachment 8483321 [details] [review]
patch in github

This would be really nice to have, but its too late to land non-ship blockers on 2.0 at this point, so unfortunately, have to minus here..

Comment 16

[Yeojin Chung [:YeojinC]]

Removing verifyme keyword per Comment 15.