1059096 - network error pages (about:neterror) have "XML Parsing Error: undefined entity" - due to Bug 1042196

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Capella [:capella]]

Currently on nightly when I go to page http://gifsforum.com/gifs/

I get : https://www.dropbox.com/s/gw50mkhdhd0vbh3/Screenshot_2014-08-27-02-51-32.png?dl=0

Looks like we missed a bit

Comment 1

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

What's interesting as this was warned against in bug 1042196 heh.

Comment 2

[Mark Capella [:capella]]

I was going to add a patch to just rename the var correctly, but I'm still puzzled at the intent there ... after I changed it and tested it locally, it runs w/o failing, but the message opens a small window that's got scrollable content below screen level so-to-speak with the "try again" button etc.

Comment 3

[Francesco Lodolo [:flod]]

Apparently not all references were renamed. e.g. https://hg.mozilla.org/mozilla-central/rev/8f00edcf2962#l2.17

Comment 5

[Daniel Holbert [:dholbert]]

In particular, we removed the entity "connectionFailure.longDesc" from the .dtd file:
>-<!ENTITY connectionFailure.longDesc "&sharedLongDesc2;">
>+<!ENTITY connectionFailure.longDesc2 "&sharedLongDesc3;">
http://hg.mozilla.org/mozilla-central/rev/8f00edcf2962#l5.12

...but we didn't remove its usage here in netError.xhtml:
>         <div id="ed_connectionFailure">&connectionFailure.longDesc;</div>
http://hg.mozilla.org/mozilla-central/rev/8f00edcf2962#l2.17

Comment 6

[Wesley Johnston (:wesj)]

Yeah, its linked in multiple places in netError. I only fixed one of 'em. Testing a fix.

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 8

[Mark Capella [:capella]]

Comment on attachment 8480079 [details] [diff] [review]
Patch

Review of attachment 8480079 [details] [diff] [review]:
-----------------------------------------------------------------

wfm ... verify that https://www.dropbox.com/s/totb7tmwvo35xo8/netError.mp4?dl=0 is the desired UI experience? (small / scrollable "Unable to connect' box) ?

Comment 9

[Wesley Johnston (:wesj)]

For now yeah. We should file something about making these responsive to small heights maybe.

Comment 11

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/c2946ccbe3ff

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: noticeable regression, might be needed if this fix bounces off 34 nightly

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2946ccbe3ff