Closed Bug 1059157 Opened 10 years ago Closed 10 years ago

Reduce the overpaint of the camera app

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

Attachments

(1 file)

camera.less.overpaint.patch
575 bytes, patch
justindarc
: review+
Details | Diff | Splinter Review
This remove some of the overpaint of the hud. It force it to cover the right area instead of the whole screen.
Attachment #8479712 - Flags: review?(dflanagan)
Comment on attachment 8479712 [details] [diff] [review] camera.less.overpaint.patch David is on PTO. Let's ask an other reviewer.
Attachment #8479712 - Flags: review?(dflanagan) → review?(dale)
Comment on attachment 8479712 [details] [diff] [review] camera.less.overpaint.patch Forwarding to gallery peer
Attachment #8479712 - Flags: review?(dale) → review?(pdahiya)
Comment on attachment 8479712 [details] [diff] [review] camera.less.overpaint.patch Over to Justin, who has been working on this a lot already.
Attachment #8479712 - Flags: review?(pdahiya) → review?(jdarcangelo)
Comment on attachment 8479712 [details] [diff] [review] camera.less.overpaint.patch Review of attachment 8479712 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! This reduces overdraw for me by 71 on Flame (JB). Please remove the extra redundant `box-sizing` declaration from hud.css. If you could too, maybe we should un-prefix the `-moz-box-sizing` declaration in app.css. Thanks again for the patch!
Attachment #8479712 - Flags: review?(jdarcangelo) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: