1059174 - Allow ServiceWorkers over http on localhost

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Jake Archibald]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.143 Safari/537.36

Steps to reproduce:

navigator.serviceWorker.register(url) on a page hosted at http://localhost:3000/


Actual results:

SecurityError: The operation is insecure.


Expected results:

Registration allowed over http on localhost

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

This is similar to bug 1003991, but slightly different.  Its unclear to me if we want both of these or just one.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: localhost.patch

Talking with bagder from the necko team, we both agreed that using the DNS was too much for this issue. This patch gives a reasonable way to manage localhost: It covers localhost, ::1, and 127.0.0.1.

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8482652 [details] [diff] [review]
localhost.patch

Review of attachment 8482652 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerManager.cpp
@@ +588,5 @@
> +    if (NS_WARN_IF(result.Failed())) {
> +      return result.ErrorCode();
> +    }
> +
> +    if (host == "127.0.0.1" || host == "localhost" || host == "::1") {

Could you use Equals()? == always stands out as 'oh this could be wrong' when literals are involved, and requires looking up to see that one of the operands is a nsAutoCString.

Comment 4

[Andrea Marchesini [:baku]]

Yes, Equals() is better.

https://hg.mozilla.org/integration/mozilla-inbound/rev/cea25477ad0f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cea25477ad0f