1059241 - array.pop() should not mark the array as non-packed

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

See the testcase below. Ion emits a hole check for the arr[1] load inside the loop, because the arr.pop() call marked the array as non-packed.

This affects deltablue.

function f() {
    var res = 0;
    var arr = [1, 2, 3];
    arr.pop();
    for (var i=0; i<1000000; i++) {
	res += arr[1];
	arr[1] = 1;
    }
}
f();

Comment 1

[Johannes Schulte [:jschulte]]

Attachment: v1.patch

Nice, 5.6 % improvement on deltablue.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8484139 [details] [diff] [review]
v1.patch

Review of attachment 8484139 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch. Forwarding to Brian.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

pushed for johannes on try as he doesn't have L1 commit access:
https://tbpl.mozilla.org/?tree=Try&rev=5d9979000d19

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/992b2c2eef2c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/992b2c2eef2c