Closed Bug 1059280 Opened 11 years ago Closed 11 years ago

The 'n' and 'p' keys don't loop around when the bottom or top of the page is reached

Categories

(Tree Management :: Treeherder, defect, P2)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: RyanVM, Assigned: wlach)

References

Details

Attachments

(1 file)

Loop around with 'n' and 'p' keys
49 bytes, text/x-github-pull-request
jeads
: review+
Details | Review
On TBPL, hitting the 'n' key when you reach the bottom unclassified failure bring you back up to the top one. Likewise the opposite for 'p'. Treeherder should do the same.
Blocks: treeherder-sheriff-transition
Priority: -- → P1
Summary: The 'n' and 'p' keys don't cycle when the bottom or top of the page is reached → The 'n' and 'p' keys don't loop around when the bottom or top of the page is reached
Priority: P1 → P3
Priority: P3 → P2
I'll take this.
Assignee: nobody → wlachance
Status: NEW → ASSIGNED
Attachment #8481663 - Flags: review?(jeads)
Comment on attachment 8481663 [details] [review] Loop around with 'n' and 'p' keys Nice fix.
Attachment #8481663 - Flags: review?(jeads) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/1f7c8df306d1a84a3eec565ec5542dc8768f99a1 Bug 1059280 - Loop around when cycling between jobs with 'n' and 'p' keys https://github.com/mozilla/treeherder/commit/daa8affe3e9b4425bcfd6fac86c056dbacfd798a Merge pull request #141 from wlach/1059280 Bug 1059280 - Loop around when cycling between jobs with 'n' and 'p'
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: