1059302 - IonMonkey MIPS Simulator: Fix printing float register values and errors on wrong register name.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Branislav Rankov [:rankov]]

Debugger for MIPS Simulator crashes when printing value of float register or entering wrong register name.

Comment 1

[Branislav Rankov [:rankov]]

Assigning to Aleksandar. Aleksandar is now starting to work with me on maintaining SpiderMonkey MIPS port.

Comment 2

[Aleksandar Zlicic]

Attachment: Bug_1059302.patch

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8481239 [details] [diff] [review]
Bug_1059302.patch

Review of attachment 8481239 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips/Simulator-mips.cpp
@@ +777,5 @@
>      printAllRegs();
>  
>      printf("\n\n");
>      // f0, f1, f2, ... f31.
> +    for (uint32_t i = 0; i < FloatRegisters::TotalSingle; i ++) {

Nit: i++ (no space)

@@ +936,5 @@
>                          if (reg != InvalidReg) {
>                              value = getRegisterValue(reg.code());
>                              printf("%s: 0x%08x %d \n", arg1, value, value);
> +                        } else if (fCode != FloatRegisters::Invalid) {
> +                            if ( fCode & 0x1 ) {

Nit: if (fCode & 0x1) {

Comment 4

[Aleksandar Zlicic]

Attachment: Bug_1059302.patch

Carry review from previous patch.

I have fixed issues noted by Jan de Mooij in comment #3.

Comment 5

[Branislav Rankov [:rankov]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a47e502dcf4

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9a47e502dcf4