1059318 - The drop-down box for components doesn't scroll

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Where's the bugzilla product?

We have so many components and products now that the component dropdown doesn't show them all, and it doesn't scroll to show the rest. It's kind of annoying, specially when all the components listed are from the same product and the component you want is in a different product entirely. (If it happens to be in the same product you can just click on a different component and then change it on the bug entry page. But you can't change the product as easily).

It would nice to either allow scrolling that dropdown box, or limit the number of components from any given product so that all the matching products are represented there.

Comment 2

[David Lawrence [:dkl]]

Attachment: 1059318_1.patch

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8493350 [details] [diff] [review]
1059318_1.patch

Review of attachment 8493350 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but I wonder if we'll get complaints on shorter screens such as 1366x768.
r=dylan

Comment 4

[:glob ✱]

Comment on attachment 8493350 [details] [diff] [review]
1059318_1.patch

Review of attachment 8493350 [details] [diff] [review]:
-----------------------------------------------------------------

due to the large number of components we have (1800), returning _all_ results isn't useful.  eg. searching for "moz" returns 1434 components.

i'd prefer to retain the upper limit on our search results but increase the limit (to, say, 100), and add an indication that the limit has been hit.
eg. "More than 100 components found .."

while you're there, can you please pass maxResults to the webservice method; while looking at this i realised we don't set the limit parameter for the call, resulting in a lot of unnecessary data in the response.

::: extensions/ProdCompSearch/web/styles/prod_comp_search.css
@@ +15,5 @@
>      width: 360px;
>  }
>  
> +#prod_comp_search_form .yui3-aclist-content {
> +    height: 500px;

this should be "max-height".  if only one component is found, this div doesn't need to be 500px high.

Comment 5

[David Lawrence [:dkl]]

Attachment: 1059318_2.patch

New patch with suggested changes.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8493888 [details] [diff] [review]
1059318_2.patch

Review of attachment 8493888 [details] [diff] [review]:
-----------------------------------------------------------------

I like that when there are fewer results, the height is shorter. But I concur with glob's previous review that we need some sort of indicator when more than the max results are returned.

Perhaps you could request max_results + 1, and when the web service returns that number, display ""More than 100 components found .."?

Comment 7

[David Lawrence [:dkl]]

Attachment: 1059318_3.patch

Ah meant to add that in the last revision but forgot. Added the message about > 100 comps.

Comment 8

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8494563 [details] [diff] [review]
1059318_3.patch

Review of attachment 8494563 [details] [diff] [review]:
-----------------------------------------------------------------

ship it :-D

r=dylan

Comment 9

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   550d53c..9f07124  master -> master