Closed
Bug 1059419
Opened 7 years ago
Closed 6 years ago
Needinfo-ing a mentor doesnt work
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Ricmacas, Assigned: dkl, Mentored)
Details
Attachments
(1 file, 1 obsolete file)
692 bytes,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce: While needinfo-ing a mentor here: https://bugzilla.mozilla.org/show_bug.cgi?id=1051221 I ran into an issue that when I selected mentor, the checkbox would be checked and the mentor's name would be filled in the box, but after submitting there was no needinfo to be seen. What should happen: Needinfo the mentor What happened: No needinfo.
Reporter | ||
Updated•7 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Mentor: lhenry
Reporter | ||
Comment 1•7 years ago
|
||
Trying it out now!
Reporter | ||
Updated•7 years ago
|
Mentor: lhenry → ricardojorgemacas
Ricardo just tried to need-info the mentor for this bug while I was assigned as mentor. That wasn't reflected in this bug and I didn't get an email. Confirming that it's a problem! :)
Help me, Obi-Wan Ricardo, you're my only hope. (This is a test!)
Reporter | ||
Comment 4•7 years ago
|
||
Ok that didnt work either.
Assignee | ||
Comment 5•7 years ago
|
||
This is probably related to some recent refactoring of the bug mentoring field on the back end. I will investigate this further. dkl
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8480096 [details] [diff] [review] 1059419_1.patch Review of attachment 8480096 [details] [diff] [review]: ----------------------------------------------------------------- putting the mentor into the 'other' field makes that field's behaviour inconsistent. when a bug is first opened, the 'other' field is empted. after selecting reporter/assignee/myself from the needinfo menu and then 'other', it is still empty. however with this patch, if you select a mentor and then 'other', the field is populated with the selected mentor. this shouldn't happen.
Attachment #8480096 -
Flags: review?(glob) → review-
Comment 8•6 years ago
|
||
resetting the assignedto field due to inactivity. I am not sure if this is still a valid bug, glob could you comment on that?
Assignee: dkl → nobody
Flags: needinfo?(glob)
yes, it's still valid. reassigning back to dkl to put on his radar.
Assignee: nobody → dkl
Flags: needinfo?(glob)
Assignee | ||
Comment 10•6 years ago
|
||
Attachment #8480096 -
Attachment is obsolete: true
Attachment #8556053 -
Flags: review?(glob)
Comment 11•6 years ago
|
||
Comment on attachment 8556053 [details] [diff] [review] 1059419_2.patch Review of attachment 8556053 [details] [diff] [review]: ----------------------------------------------------------------- nice; r=glob, with cache=>1 to be fixed on commit. ::: extensions/Needinfo/Extension.pm @@ +121,5 @@ > $requestees{$requestee_obj->login} = 1; > } > } > + # Requestee is a mentor > + elsif ($needinfo_role && Bugzilla::User->check($needinfo_role)) { Bugzilla::User->check do a cached check.. ->check({ name => $needinfo_role, cache => 1 })
Attachment #8556053 -
Flags: review?(glob) → review+
Assignee | ||
Comment 12•6 years ago
|
||
Sorry for the delay in fixing this. Should be in production soon. To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git ece0cae..89d3199 master -> master dkl
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•1 year ago
|
Component: Extensions: Needinfo → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•