Closed
Bug 1059432
Opened 11 years ago
Closed 11 years ago
UI updates for frame selection command button
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(2 files)
|
1.61 KB,
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
|
46.85 KB,
image/png
|
Details |
frame-button.png
The command button for frame selection doesn't match the other ones. Most importantly, it's background color is different (especially noticeable on the dark theme).
|
Assignee | |
Comment 1•11 years ago
|
||
Updates styles for frame button (screenshot incoming)
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8480054 -
Flags: review?(poirot.alex)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Two things you can see in the screenshot: matching bg color and a tiny bit more left-right padding in the new one. There is one more thing you can't see in the screenshot that has to do with the icon not flickering color changes when hovering and opening the popup (you really have to compare opening the menu before and after the patch to see that change)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8480054 [details] [diff] [review]
frame-button-styles.patch
Review of attachment 8480054 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the tweaks!
Attachment #8480054 -
Flags: review?(poirot.alex) → review+
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
|
||
Updated•11 years ago
|
QA Whiteboard: [good first verify]
|
||
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•