Closed Bug 1059432 Opened 6 years ago Closed 6 years ago

UI updates for frame selection command button

Categories

(DevTools :: Framework, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(2 files)

The command button for frame selection doesn't match the other ones.  Most importantly, it's background color is different (especially noticeable on the dark theme).
Updates styles for frame button (screenshot incoming)
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8480054 - Flags: review?(poirot.alex)
Attached image frame-button.png
Two things you can see in the screenshot: matching bg color and a tiny bit more left-right padding in the new one.  There is one more thing you can't see in the screenshot that has to do with the icon not flickering color changes when hovering and opening the popup (you really have to compare opening the menu before and after the patch to see that change)
Comment on attachment 8480054 [details] [diff] [review]
frame-button-styles.patch

Review of attachment 8480054 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the tweaks!
Attachment #8480054 - Flags: review?(poirot.alex) → review+
https://hg.mozilla.org/mozilla-central/rev/3fa315846f97
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
QA Whiteboard: [good first verify]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.