Closed Bug 1059548 Opened 8 years ago Closed 8 years ago

enable sync of privacy.trackingprotection.enabled pref

Categories

(Core :: DOM: Security, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla35

People

(Reporter: mmc, Assigned: francois)

References

Details

Attachments

(3 files)

Seems like a good thing to sync.
Assignee: nobody → francois
Summary: enable sync on privacy.trackingprotection.enabled → enable sync of privacy.trackingprotection.enabled pref
Attached patch v1 for reviewSplinter Review
I've tested that this is all we need to get a new browser profile to pull the setting from Sync.
Attachment #8485586 - Flags: review?(mmc)
Status: NEW → ASSIGNED
Comment on attachment 8485586 [details] [diff] [review]
v1 for review

Review of attachment 8485586 [details] [diff] [review]:
-----------------------------------------------------------------

Fantastic, I was hoping it was going to be that easy :)
Attachment #8485586 - Flags: review?(mmc) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b074336ad3f1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Hey Francois,

Does this sync to fennec? If so, that's problematic because the UI isn't working there right now (https://bugzilla.mozilla.org/show_bug.cgi?id=1063831).

Thanks,
Monica
Flags: needinfo?(francois)
Monica: I don't know, but I can try and figure out how to build fennec and then test it.
Flags: needinfo?(francois)
I logged into FxA using my account which has trackingprotection enabled and then forced a Sync of fennec. Tracking protection is still disabled (see screenshot).
My theory is that fennec doesn't actually sync prefs from desktop. If you look at the Sync settings on fennec (see attached screenshots), there is no way to enable/disable the syncing of prefs.
Verified as fixed using:

FF 35 Aurora
Build Id:20141022004003
OS: Win 7 x64, Mac Os X 10.9.5, Ubuntu 14.04 x64
Status: RESOLVED → VERIFIED
Blocks: 1202146
You need to log in before you can comment on or make changes to this bug.