1059548 - enable sync of privacy.trackingprotection.enabled pref

Status: VERIFIED FIXED

(Core :: DOM: Security, defect)

Description

[[:mmc] Monica Chew (no longer reading bugmail)]

Seems like a good thing to sync.

Comment 1

[François Marier [:francois]]

Attachment: v1 for review

I've tested that this is all we need to get a new browser profile to pull the setting from Sync.

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8485586 [details] [diff] [review]
v1 for review

Review of attachment 8485586 [details] [diff] [review]:
-----------------------------------------------------------------

Fantastic, I was hoping it was going to be that easy :)

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b074336ad3f1

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b074336ad3f1

Comment 5

[[:mmc] Monica Chew (no longer reading bugmail)]

Hey Francois,

Does this sync to fennec? If so, that's problematic because the UI isn't working there right now (https://bugzilla.mozilla.org/show_bug.cgi?id=1063831).

Thanks,
Monica

Comment 6

[François Marier [:francois]]

Monica: I don't know, but I can try and figure out how to build fennec and then test it.

Comment 7

[François Marier [:francois]]

Attachment: about-config-fennec-nightly.jpg

I logged into FxA using my account which has trackingprotection enabled and then forced a Sync of fennec. Tracking protection is still disabled (see screenshot).

Comment 8

[François Marier [:francois]]

Attachment: sync-settings-fennec-nightly.jpg

My theory is that fennec doesn't actually sync prefs from desktop. If you look at the Sync settings on fennec (see attached screenshots), there is no way to enable/disable the syncing of prefs.

Comment 9

[[:mmc] Monica Chew (no longer reading bugmail)]

OK, great. Searching for https://mxr.mozilla.org/mozilla-central/search?string=services.sync.prefs.sync&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central also reveals nothing in mobile. Thanks!

Comment 10

[Catalin Varga [QA][:VarCat]]

Verified as fixed using:

FF 35 Aurora
Build Id:20141022004003
OS: Win 7 x64, Mac Os X 10.9.5, Ubuntu 14.04 x64