1059680 - [e10s][TSF][IMM32] IME should be able to handle mouse events fired in content process

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

bug 826657 implements new notification for IME of mouse button event. This is notified from IMEContentObserver to widget. So, this can notify synchronously.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8480574 [details] [diff] [review]
Patch

I'm not sure if Smaug, you are a good reviewer for this patch, though.

This patch supports NS_NOTIFY_IME_OF_MOUSE_BUTTON_EVENT in e10s mode. It must be synchronous API because it needs to check if IME consumes the notified mouse button event.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8480574 [details] [diff] [review]
Patch

Hopefully this doesn't feel too nitpicking, but I'd prefer
having a ParamTraits for IMENotification.
Put it perhaps to TabMessageUtils.h?
I think ParamTraits would keep the code easier to read.

If you have a reason to not add ParamTraits, feel free to ask review for this
patch again.
(I think it is fine except static_asserts could be in a row and the assignments after them. That would improve readability.)

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

This patch uses nsGUIEventIPC.h because it defines some other struct/class in nsIWidget.h too.

# I guess that the file name should be renamed in another bug. Perhaps, WidgetIPC.h?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

WidgetIPC.h could work, though the code which the patch adds to nsGUIEventIPC.h is rather
event handling related.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thanks. I'll file a follow up bug.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b6a2d4be6c0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8b6a2d4be6c0