1059690 - [RocketBar] close button can be moved a couple of pixels to the right

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: CloseButton.png

### STR
1. 'Tap Search or enter address'.
2. tap and hold the 'Close' button, and it can be moved to the right.

### Actual
CloseButton.png
http://youtu.be/b6f96C0PXqQ

### Version
Gaia      3a838afca295c9db32e1a3ec76d49fb7fe7fd2d2
Gecko     https://hg.mozilla.org/mozilla-central/rev/5f0b5cc8f78d
BuildID   20140827160207
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 1

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]: Weird UI

Comment 2

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]: Weird UI

Comment 3

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8482528 [details] [review]
Pull request

Thanks for the patch, but it does not seem to fix the issue for me. When I long press on "close" I still see the text shift under my fingers.

I wonder if this is a problem with the rocketbar-form selectors or flex layout?

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8482528 [details] [review]
Pull request

Nevermind, maybe I did not properly apply the patch, but it appears to work for me. Thanks!

Comment 6

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/43d783995e8bdc9bbc2ff9b801339983be417522

Comment 7

[Kevin Grandon :kgrandon]

Oops, not sure why I changed that flag earlier.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8482528 [details] [review]
Pull request

Alternatively requesting approval for 2.1 if we don't get blocking here.

This is a super trivial 1-liner visual tweak. Thanks!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/779e82f6f8abef786426c00297c915f6a8e2c013

Comment 10

[John Thomas [:Johnt]]

This issue does NOT occur on the Flame 2.2 Master (319mb) and the Flame 2.1 KK (319mb)

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: Close button can no longer be moved for 2.1 and 2.2.

Comment 11

[John Thomas [:Johnt]]

Fix has not yet been uplifted to 2.0 as it is still affected by this issue. Leaving keyword verifyme.

Comment 12

[Kevin Grandon :kgrandon]

(In reply to John Thomas [:Johnt] from comment #11)
> Fix has not yet been uplifted to 2.0 as it is still affected by this issue.
> Leaving keyword verifyme.

Question - it's not blocking 2.0 so why would we leave the verifyme keyword if we're not planning on fixing that branch?

Comment 13

[Yeojin Chung [:YeojinC]]

Removing verifyme keyword per Comment 12.