1059698 - [OPEN 2_1.3]The streaming video volume in headset is too low

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[chencong]

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.143 Safari/537.36

Steps to reproduce:

1） Play Youtube video with headset；
2） Play Youtube video with speaker;
3） Play local video on the phone with headset;


Actual results:

1） When play Youtube video with headset, the volume is too low to hear.
2） When play Youtube video with speaker, the volume is normal.  It is OK.
3） When play local video with headset, the volume is normal. It is OK.


Expected results:

1) When play Youtube video with headset, the volume should be normal.

Comment 1

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

hum....didn't see other ODM complained about streaming volume...So how about Open C? Also has low volume?

Thanks

Comment 2

[chencong]

hi vance,

The Openc C has the same issue. The volume of stream video with headset is lower than the local video when user add it to max volume value.

Comment 3

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

I did the dumpsys and found stream volume's maximum value is 0.06 (Normally, it should be 1).
Identify the browser open audio track as system type to play the video. 

Refer to AudioPolicyManagerBase.cpp: computeVolume function and it contains some logic to reduce the headset volume and avoid hurt people ear on streamType equal "system".
So that cause the different behavior between headset and speaker.

Comment 4

[chencong]

Hi Lin and Vance,

Would you please give me some advices to modify this issue?
This issue causes the user to return the phone.

Thanks.

Comment 5

[Star Cheng [:scheng]]

Attachment: bug-1059698.patch

Map "Normal" audio channel type to "music" stream type.

Comment 7

[Star Cheng [:scheng]]

Comment on attachment 8484863 [details] [diff] [review]
bug-1059698.patch


Hi, Baku

We try to map "Normal" audio channel type to "music" stream type instead of "System" stream type. Because a headset is connected, AudioPolicyManagerBase apply the certain rules[1] to decrease volume [2]. 

This causes that there are different volume between speaker & headset for "Normal" channel type(i.e. "system" stream type).


[1] http://androidxref.com/4.4.4_r1/xref/hardware/libhardware_legacy/audio/AudioPolicyManagerBase.cpp#3028
[2] http://androidxref.com/4.4.4_r1/xref/hardware/libhardware_legacy/audio/AudioPolicyManagerBase.cpp#3032

Comment 8

[Andrea Marchesini [:baku]]

Comment on attachment 8484863 [details] [diff] [review]
bug-1059698.patch

Review of attachment 8484863 [details] [diff] [review]:
-----------------------------------------------------------------

scheng, I don't know the implication of this choice.
You know this code more than me to say if changing this setting is fine.
If you say that is ok, and you have check any possible regression, to me is ok.
Plus, I cannot give you r+ because I'm not a peer of cubeb or media in general.

Comment 9

[Star Cheng [:scheng]]

Hi, Matthew

Could you help to review this patch?

Comment 10

[Matthew Gregan [:kinetik]]

Comment on attachment 8484863 [details] [diff] [review]
bug-1059698.patch

Review of attachment 8484863 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/CubebUtils.cpp
@@ -150,5 @@
>  /*static*/ cubeb_stream_type CubebUtils::ConvertChannelToCubebType(dom::AudioChannel aChannel)
>  {
>    switch(aChannel) {
>      case dom::AudioChannel::Normal:
> -      return CUBEB_STREAM_TYPE_SYSTEM;

Put a /* FALLTHROUGH */ comment here, or just change the return type to TYPE_MUSIC.

Comment 11

[Star Cheng [:scheng]]

Attachment: bug-1059698-fix.patch

1. add "/* FALLTHROUGH */ comment" to the patch
2. add reviewer as kinetik

And wait for TPBL result : https://tbpl.mozilla.org/?tree=Try&rev=0493f2ae9a42.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/2a56d1188826

Comment 14

[Jeremiah Lee]

Also happens in music streaming apps (grooveshark, for ex).

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2a56d1188826