Closed Bug 1059705 Opened 5 years ago Closed 5 years ago

revert the change which made nsIEditor builtinclass

Categories

(Core :: Editor, defect)

29 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file, 1 obsolete file)

At least for now nsIEditor should be implementable in JS.
We should probably figure out what the Thunderbird addons are doing and give them
some other options than re-implementing rather complicated interface...and then
make nsIEditor builtinclass again.
Assignee: nobody → bugs
Attached patch patch (obsolete) — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=fa37fdc8216f
Attachment #8480483 - Flags: review?(masayuki)
Comment on attachment 8480483 [details] [diff] [review]
patch

>-  [infallible, noscript] readonly attribute boolean isInEditAction;
>+  readonly attribute boolean isInEditAction;

Ehsan liked [noscript] this (bug 1053048 comment 17). If it's possible without "builtinclass", it should be, I think.
Attachment #8480483 - Flags: review?(masayuki) → review+
That should work.
Sigh.  Why did we not wait for the discussion on tb-planning to at least get somewhere?
https://hg.mozilla.org/mozilla-central/rev/1082e4e90b14
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Because we're close to an uplift and the fix in this case was trivial.
See bug 1060051 "Resolve obstacles that require Conversations to wrap nsIEditor"
You need to log in before you can comment on or make changes to this bug.