1059705 - revert the change which made nsIEditor builtinclass

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

At least for now nsIEditor should be implementable in JS.
We should probably figure out what the Thunderbird addons are doing and give them
some other options than re-implementing rather complicated interface...and then
make nsIEditor builtinclass again.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=fa37fdc8216f

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8480483 [details] [diff] [review]
patch

>-  [infallible, noscript] readonly attribute boolean isInEditAction;
>+  readonly attribute boolean isInEditAction;

Ehsan liked [noscript] this (bug 1053048 comment 17). If it's possible without "builtinclass", it should be, I think.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

That should work.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: [noscript]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1082e4e90b14

Comment 5

[(no longer active)]

Sigh.  Why did we not wait for the discussion on tb-planning to at least get somewhere?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1082e4e90b14

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Because we're close to an uplift and the fix in this case was trivial.

Comment 8

[Kent James (:rkent)]

See bug 1060051 "Resolve obstacles that require Conversations to wrap nsIEditor"

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

FYI: Now, we can make nsIEditor builtinclass again because of bug 1069518.