1059706 - [Toolkit] Throw errors, not strings or numbers

Status: NEW

(Toolkit :: General, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Many items in toolkit/ call `throw Components.results.XXX` or even `throw someString`. This makes debugging much more complicated, as numbers/strings do not contain any stack information.

We should fix this.

I will mark this as a mentored good first bug, although we will want to decompose this into smaller bugs to simplify reviews and landing.

Comment 1

[Rajat Agarwal]

Hi,
I am interested in fixing this. I would be glad if you gave me more insight.

Thanks, 
Rajat

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Thanks for your interest, Rajat. Let's start with bug 394686, which is a subset of this bug.

Comment 3

[Nicholas Nethercote [inactive]]

Is this causing problems in practice? I'm not opposed to fixing it, I'm just curious. Thanks.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Yeah, this kind of practice has been known to cause friggingly-hard-to-to-debug warnings, e.g. bug 1059329.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Removing the "mentored" status, as I have divided the bug into smaller (mentored) tasks.