Closed Bug 1059725 Opened 10 years ago Closed 10 years ago

mingw-w64 compilation fails with 'WTypes.h: No such file or directory'

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Version:
31 Branch
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 856566

People

(Reporter: gk, Unassigned)

Details

Compiling Firefox ESR 31 with mingw-w64 based on GCC 4.9.1 and mingw-w64 trunk fails with "fatal error: WTypes.h: No such file or directory".
I forgot to mention this happens in toolkit/crashreporter/google-breakpad/src/google_breakpad/common/breakpad_types.h line 61. The solution seems easy: just change "WTypes.h" to "wtypes.h". Not sure how to patch a third party library, though. Both in Mozilla code and upstream?
Breakpad patches should technically go in breakpad.appspot.com, but this sounds trivial so if you provide a patch against the Mozilla source I will land it upstream for you.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Breakpad patches should technically go in breakpad.appspot.com, but this
> sounds trivial so if you provide a patch against the Mozilla source I will
> land it upstream for you.

Thanks. I wonder whether we should take a different approach and resolve this one as a duplicate of bug 856566 (which contains the fix as well) and get that reviewed and merged?
Flags: needinfo?(ted)
Yeah, let's do that. I reviewed the patch in that bug.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(ted)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.