105973 - Random observers stopped working after checkin for bug 99163

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[jag (Peter Annema)]

Potential left-overs from bug 99163:

./extensions/inspector/resources/content/sidebar.js:  Observe: function(aWindow)

./extensions/inspector/resources/content/sidebar/InspectorSidebar.js:  Observe:
function(aWindow)

./extensions/inspector/resources/content/sidebar/InspectorSidebar.js:  Observe:
function(aSubject, aTopic, aData)

./extensions/inspector/resources/content/viewers/dom/dom.js:  Observe:
function(aSubject, aTopic, aData)

./extensions/vixen/resources/content/history/history.js:  Observe: function
(aSubject, aTopic, aData) 

./extensions/wallet/resources/content/walletNavigatorOverlay.xul:   
navObserver.prototype.Observe = function (subject, message, contextUrl) {

./js/src/xpconnect/tests/js/old/xpctest_observer.js:    Observe :
function(aSubject, aTopic, someData) {

./js/src/xpconnect/tests/js/old/xpctest_observer.js:    Observe :
function(aSubject, aTopic, someData) {

./xpfe/browser/resources/content/navigator.js:  Observe: function(subject,
topic, prefName)

./xpfe/communicator/resources/content/utilityOverlay.js:  Observe:
function(subject, topic, state) {

./xpfe/components/related/resources/related-panel.js:NavObserver.prototype.Observe
=

./xpfe/components/xfer/resources/downloadProgress.js:    Observe: function(
subject, topic, data ) {

./mailnews/base/resources/content/commandglue.js:  Observe: function(subject,
topic, state) {

./mailnews/compose/resources/content/MsgComposeCommands.js:  Observe:
function(subject, topic, state) {

./mailnews/compose/resources/content/MsgComposeCommands.js:  Observe:
function(subject, topic, value) {

Comment 1

[jag (Peter Annema)]

Attachment: Fix missed changes in js code.

Comment 2

[jag (Peter Annema)]

And checked in. Leaving this bug open for now as a placeholder in case I find
some more places.

Comment 3

[jag (Peter Annema)]

MarkH: I'm guessing that this python code will need to be fixed too:

./extensions/python/xpcom/components.py:    def Observe(self, service, topic,
extra):

http://lxr.mozilla.org/seamonkey/source/extensions/python/xpcom/components.py#188

I've additionally found these two and fixed them (rev 1.11):

./xpfe/browser/resources/content/urlbarBindings.xml:          Observe:
function(aObserver, aBlah, aPref) {

./xpfe/browser/resources/content/urlbarBindings.xml:          Observe:
function(aObserver, aBlah, aPref) {

Comment 4

[jag (Peter Annema)]

Not seeing your download make any progress can do this to someone ;-)

Comment 5

[Doug Turner (:dougt)]

marking this fix.  reopen if any others are found.

Thank you for you help, jag!!!