1059801 - Newly seen machines don't have a valid timestamp set by add_machine()

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

{
    def add_machine(self, machine_name, timestamp):
        """
        Add machine name and timestamp. There are two timestamps stored in
        the database for each machine, one associated with the first time
        the machine is seen and another that acts as a heartbeat for the
        machine.
        """

        if machine_name not in self.machine_name_lookup:

            machine_name = machine_name or 'unknown'
            timestame = timestamp or time.time()

            machine_name = machine_name[0:50]

            self.machine_name_lookup.add(machine_name)

            # Placeholders for the INSERT/SELECT SQL query
            self.machine_name_placeholders.append(
                # machine_name, first_timestamp, last_timestamp,
                # machine_name
                [ machine_name, timestamp, timestamp, machine_name ]
                )
}

Due to 'timestame' rather than 'timestamp'.

Comment 1

[Ed Morley [:emorley]]

Attachment: Fix fallback for when no timestamp is passed to add_machine()

Git log says jeads wins the review roulette :-)

Comment 2

[Jonathan Eads ( :jeads )]

Comment on attachment 8480590 [details] [diff] [review]
Fix fallback for when no timestamp is passed to add_machine()

Review of attachment 8480590 [details] [diff] [review]:
-----------------------------------------------------------------

Nice typo catch.

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8480590 [details] [diff] [review]
Fix fallback for when no timestamp is passed to add_machine()

https://github.com/mozilla/treeherder-service/commit/d6e3cd8ed37d6a6ec26de4c2629bcadf7659b213