1059822 - [LockScreen] SIM pin request page in front of camera when rebooting, sim pin on and unlock to camera

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: 2014-08-28-08-46-16.png

### STR
1. Turn SIM pin on, lock screen on. 
2. Reboot.
3. Slide to Camera

### Actual
SIM pin page shown on top of camera
2014-08-28-08-46-16.png

### Version 
Gaia      3a838afca295c9db32e1a3ec76d49fb7fe7fd2d2
Gecko     https://hg.mozilla.org/mozilla-central/rev/5f0b5cc8f78d
BuildID   20140827160207
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 1

[Eric Chang [:ericcc] [:echang]]

Hi Alive, Could you take a look at this, thank you.

[Blocking Requested - why for this release]: SIM pin request is unnecessary for accessing camera here.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Looks like a regression, please help to find out the regression window.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

I cannot reproduce with latest master.

Comment 4

[Eric Chang [:ericcc] [:echang]]

Last good build
https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-central-flame-eng/2014/05/2014-05-29-04-02-01/

20140523160204 okay
20140527160201 okay
20140529040201 okay
20140529113510 fail
20140529160204 fail
20140531160201 fail

20140827160207 fail

Comment 5

[Pi Wei Cheng [:piwei] (inactive)]

I'm unable to reproduce this issue on Flame 2.1 and Flame 2.0.

Observed behavior: After reboot, sliding LEFT to launch camera from lockscreen is successful - no SIM pin is requested in this scenario. Repro rate 0/6 on 2.1, and 0/3 on 2.0.

Tested on:
Device: Flame
BuildID: 20140829061359
Gaia: 007f3c50cf69f044628a23c2376c6d88aa45f617
Gecko: d728b2f31c56
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Device: Flame
BuildID: 20140827201151
Gaia: ee5cf3aff7e66ec5e899bdffa27ef51bfa40f0f0
Gecko: 218771782328
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 6

[Joshua Mitchell (Inactive)]

Eric - several people have not been able to repro on the latest master - your tests indicated testing from 2 days ago - when you get the time would you mind checking in the latest build?

Comment 7

[Eric Chang [:ericcc] [:echang]]

I still can reproduce this with today's master, firmware 123, 1GB ram, I've asked help from Alive to see what goes wrong.

Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
BuildID   20140831160203
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Eric Chang [:ericcc] [:echang] from comment #7)
> I still can reproduce this with today's master, firmware 123, 1GB ram, I've
> asked help from Alive to see what goes wrong.
> 
> Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
> Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
> BuildID   20140831160203
> Version   34.0a1
> ro.build.version.incremental=110
> ro.build.date=Fri Jun 27 15:57:58 CST 2014
> B1TC00011230

Please apply this patch and give me logcat when u repro it.
https://github.com/mozilla-b2g/gaia/pull/23552

Comment 9

[Eric Chang [:ericcc] [:echang]]

Attachment: v2.1_CAMERA_LOCKSCREEN.LOG

Note:
1. Flashing gaia.zip from PVT -> reproducible
2. $GAIA_OPTIMIZE=1 Make reset-gaia from github -> reproducible
3. $Make reset-gaia from github -> Not reproducible

Log collected from method 2.

(In reply to Alive Kuo [:alive][NEEDINFO!][PTO until 9/9] from comment #8)
> (In reply to Eric Chang [:ericcc] [:echang] from comment #7)
> > I still can reproduce this with today's master, firmware 123, 1GB ram, I've
> > asked help from Alive to see what goes wrong.
> > 
> > Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
> > Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
> > BuildID   20140831160203
> > Version   34.0a1
> > ro.build.version.incremental=110
> > ro.build.date=Fri Jun 27 15:57:58 CST 2014
> > B1TC00011230
> 
> Please apply this patch and give me logcat when u repro it.
> https://github.com/mozilla-b2g/gaia/pull/23552

Comment 10

[Rachel Pribble [:rpribble]]

B2G Inbound Last Working:
Device: Flame 2.1
BuildID: 20140828230659
Gaia: f087c45c328f16bf6f8d5a4d9452fa9a27aa6c7b
Gecko: 2162e10743be
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

B2G Inbound First Broken:
Device: Flame 2.1
BuildID: 20140828234459
Gaia: f087c45c328f16bf6f8d5a4d9452fa9a27aa6c7b
Gecko: a57d1aa27da9
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Swap:
First broken gecko/Last working gaia - Issue DOES reproduce
Gaia: f087c45c328f16bf6f8d5a4d9452fa9a27aa6c7b
Gecko: a57d1aa27da9

First broken gaia/Last working gecko - Issue DOES NOT reproduce
Gaia: f087c45c328f16bf6f8d5a4d9452fa9a27aa6c7b
Gecko: 2162e10743be

Gecko pushlog:
http://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=2162e10743be&tochange=a57d1aa27da9

Possibly broken by:
Bug 1013847

Comment 11

[Jason Smith [:jsmith]]

Eric - Why isn't this nominated to 2.0 if 2.0 is affected?

Comment 12

[Joshua Mitchell (Inactive)]

Broken by  Bug 1013847 ?  Edgar - can you take a look?

Comment 13

[Edgar Chen [:edgar]]

(In reply to Joshua Mitchell [:Joshua_M] from comment #12)
> Broken by  Bug 1013847 ?  Edgar - can you take a look?

I can reproduce this issue on BuildID:20140829040202 (master) [1] which doesn't include the fix of bug 1013847.
It seems there is nothing related to bug 1013847.

[1] https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-central-flame/2014/08/2014-08-29-04-02-02/

Comment 14

[Eric Chang [:ericcc] [:echang]]

I missed that.
[Blocking Requested - why for this release]: SIM pin request is unnecessary for accessing camera here.
(In reply to Jason Smith [:jsmith] from comment #11)
> Eric - Why isn't this nominated to 2.0 if 2.0 is affected?

Comment 15

[Jason Smith [:jsmith]]

Flagging window wanted again since this reproduces without the fix in bug 1013847.

Comment 16

[howie [:howie]]

Hi Alive, can you be the owner of this?

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Eric Chang [:ericcc] [:echang] from comment #9)
> Created attachment 8483344 [details]
> v2.1_CAMERA_LOCKSCREEN.LOG
> 
> Note:
> 1. Flashing gaia.zip from PVT -> reproducible
> 2. $GAIA_OPTIMIZE=1 Make reset-gaia from github -> reproducible
> 3. $Make reset-gaia from github -> Not reproducible
> 
> Log collected from method 2.
> 
> (In reply to Alive Kuo [:alive][NEEDINFO!][PTO until 9/9] from comment #8)
> > (In reply to Eric Chang [:ericcc] [:echang] from comment #7)
> > > I still can reproduce this with today's master, firmware 123, 1GB ram, I've
> > > asked help from Alive to see what goes wrong.
> > > 
> > > Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
> > > Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
> > > BuildID   20140831160203
> > > Version   34.0a1
> > > ro.build.version.incremental=110
> > > ro.build.date=Fri Jun 27 15:57:58 CST 2014
> > > B1TC00011230
> > 
> > Please apply this patch and give me logcat when u repro it.
> > https://github.com/mozilla-b2g/gaia/pull/23552

This log does not tell anything because you didn't use my patch. Please do it again because I have difficulty to repro it anyway.

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #17)
> (In reply to Eric Chang [:ericcc] [:echang] from comment #9)
> > Created attachment 8483344 [details]
> > v2.1_CAMERA_LOCKSCREEN.LOG
> > 
> > Note:
> > 1. Flashing gaia.zip from PVT -> reproducible
> > 2. $GAIA_OPTIMIZE=1 Make reset-gaia from github -> reproducible
> > 3. $Make reset-gaia from github -> Not reproducible
> > 
> > Log collected from method 2.
> > 
> > (In reply to Alive Kuo [:alive][NEEDINFO!][PTO until 9/9] from comment #8)
> > > (In reply to Eric Chang [:ericcc] [:echang] from comment #7)
> > > > I still can reproduce this with today's master, firmware 123, 1GB ram, I've
> > > > asked help from Alive to see what goes wrong.
> > > > 
> > > > Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
> > > > Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
> > > > BuildID   20140831160203
> > > > Version   34.0a1
> > > > ro.build.version.incremental=110
> > > > ro.build.date=Fri Jun 27 15:57:58 CST 2014
> > > > B1TC00011230
> > > 
> > > Please apply this patch and give me logcat when u repro it.
> > > https://github.com/mozilla-b2g/gaia/pull/23552
> 
> This log does not tell anything because you didn't use my patch. Please do
> it again because I have difficulty to repro it anyway.


Correction: From comment it seems this only happen in production build. Investigating.

Comment 19

[(Inactive after June) George Duan [:gduan] [:喬智]]

I think it doesn't matter if it's GAIA_OPTIMIZE=1 or not. I can reproduce it on both.

I can reproduce it on today's central build but cannot on 20140823040201 with the same gaia.

Comment 20

[Adam Alldredge [:AdamA][Inactive]]

I checked this regression window and came to the same results as the one that was posted by Rachel in Comment 10. Additionally, I was unable to reproduce this issue in the build mentioned in Comment 13 or the build previous to it.

Environmental Variables:
Device: Flame 2.1
BuildID: 20140829040202
Gaia: 007f3c50cf69f044628a23c2376c6d88aa45f617
Gecko: d697d649c765
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Repro Rate: 0/10

Environmental Variables:
Device: Flame 2.1
BuildID: 20140828040204
Gaia: 3a838afca295c9db32e1a3ec76d49fb7fe7fd2d2
Gecko: 3be45b58fc47
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Repro Rate: 0/5

Comment 21

[Joshua Mitchell (Inactive)]

(In reply to Jason Smith [:jsmith] from comment #15)
> Flagging window wanted again since this reproduces without the fix in bug
> 1013847.

Comment 19 and Comment 20 are indicating that this is not correct. Perhaps there is some other bug or flash process that is masking the repro here or changing the repro rate. I'm not sure.

Comment 22

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Edgar,
I tried to dump message here
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/sim_lock.js#L35
and I found that, there's no simslot-cardstatechange event when boot up on 0823's gecko, but it does on latest gecko (same gaia). Is that expected?

Comment 23

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Alive,
the root cause is timing issue of cardstatechange event, which is fired earlier than lockscreen when bootup, so simcarddialog is showed behind lockscreen and the height is not correct since lockscreen also have status bar's height.

My solution is to close SimPinDialog if we try to launch camera from lockscreen.
Please kindly check. Thanks.

Comment 24

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8486953 [details] [review]
PR to master

Great, thanks!

Comment 25

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
merge to master:
https://github.com/mozilla-b2g/gaia/commit/d0c806a1827f76977e72b39aa72cac54a4cf6cdd

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.0 and v2.1 approval on this when you get a chance.

Comment 27

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.0

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1059822
[User impact] if declined: cause failure like attachment 8480603 [details]
[Testing completed]: unit test has updated
[Risk to taking this patch] (and alternatives if risky): None.
[String changes made]: None.

Comment 28

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1059822
[User impact] if declined: cause failure like attachment 8480603 [details]
[Testing completed]: unit test has updated
[Risk to taking this patch] (and alternatives if risky): None.
[String changes made]: None.

Comment 29

[bhavana bajaj [:bajaj]]

Comment on attachment 8487660 [details] [review]
PR to 2.0

Requesting QA verification once this lands on 2.0

Comment 30

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/289629f5ab4e0c3425a553d411bac5c702314535
v2.0: https://github.com/mozilla-b2g/gaia/commit/fe838db6d5d62b9cd26b8269b58638d95b0897b6

Comment 31

[William Hsu [:whsu]]

Thanks everyone.
Verified this patch on v2.0. Cannot reproduce it on latest Flame KK build.

* Build Information:
 - Gaia        7edd3b0b9f65c3dde235c732d270e43e055a1254
 - Gecko       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/13e04ab68621
 - BuildID     20140914162307
 - Version     32.0
 - Base image  Flame KK
 - ro.build.version.incremental=27
 - ro.build.date=Thu Sep  4 14:59:02 CST 2014

Comment 32

[SandKing]

Attachment: Verified video: verify_1059822.mp4

Comment 33

[SandKing]

This issue has been verified successfully on Flame2.0&2.1&2.2
Verify video:"verify_1059822.mp4".

Flame2.0 build
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141201.034308
FW-Date         Mon Dec  1 03:43:18 EST 2014

Flame2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141201.034405
FW-Date         Mon Dec  1 03:44:15 EST 2014
Bootloader      L1TC00011880

Flame2.2 bulid:
Gaia-Rev        39214fb22c203e8849aaa1c27b773eeb73212921
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/08be3008650f
Build-ID        20141201040205
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141201.074509
FW-Date         Mon Dec  1 07:45:20 EST 2014