1059827 - [7'' Tablet] First-run window navigation buttons are hidden in landscape

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[u421692]

Attachment: screenshot

Environment:
Device: Samsung Galaxy Tab 2(Android 4.2.2)
Build: Nightly 34.0a1(2014-08-28)

Steps to reproduce:
1. Open a fresh installed Nightly
2. Put the device in landscape mode
3. Observe the First-run window

Expected result:
First-run window is displayed without any issues

Actual result:
First-run window navigation buttons are not visible(see attached screenshot)

Comment 2

[Chenxia Liu [:liuche]]

Landscape mode in Asus Nexus 7, Galaxy Note 8.0, Galaxy Tab 3

The dialog size is hard-coded for tablets - it makes the layout cleaner, but I think we just need to set height minimum by screen size.

Comment 3

[Chenxia Liu [:liuche]]

Attachment: Patch: Don't hard-code dialog height

Since the landscape/v2 mocks and design are still in progress, we should do a quick fix for the current landscape version and uplift so it's not broken on 7" tablets.

This just removes the hard-coding for the onboarding screen height so that we don't need to complicate the layouts that are currently shared between tablet/phone. The v2 for onboarding will have a design for the landscape orientation.

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 8487591 [details] [diff] [review]
Patch: Don't hard-code dialog height

Review of attachment 8487591 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little worried by this. If the intro content is short enough, it seems like this would wrap it and the buttons. Maybe thats what we want though :) Looks fine locally.

Comment 5

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/155871851e7d

Comment 6

[Chenxia Liu [:liuche]]

Comment on attachment 8487591 [details] [diff] [review]
Patch: Don't hard-code dialog height

Approval Request Comment
[Feature/regressing bug #]: Landscape on small tablets not handled correctly by bug 1042809
[User impact if declined]: Landscape 7" tablets will have a cut off first run screen
[Describe test coverage new/current, TBPL]: local
[Risks and why]: very low, remove hard-coding for a resource dimension
[String/UUID change made/needed]: none

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/155871851e7d

Comment 8

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in:
Build: Firefox for Android 35.0a1 (2014-09-14)
Device: Kindle Fire HD 7"

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8487591 [details] [diff] [review]
Patch: Don't hard-code dialog height

Aurora+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f55c10f49f50

Comment 11

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in:
Build: Firefox for Android 34.0a2 (2014-09-17)
Device: Kindle Fire HD 7"