1059890 - Fennec armv6 esr31 differences between release and nightly in-tree configs that are not whitelisted

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Pete Moore [:pmoore][:pete]]

[[e-mail] staging]$ source bin/activate

(staging)[[e-mail] staging]$ 'python' 'tools/buildbot-helpers/release_sanity.py' '--branch' 'mozilla-esr31' '--username' 'shipit' '--version' '33.0b1' '--build-number' '1' '--release-config' 'staging_release-fennec-mozilla-esr31.py' '--skip-verify-configs' '--masters-json-file' '/builds/buildbot/pmoore/staging/staging/master/master_config.json' '--configs-dir' 'buildbot-configs' '--configs-branch' 'production' '--dry-run'

2014-08-28 09:38:32,381 : INFO : command: START
2014-08-28 09:38:32,381 : INFO : command: buildbot --version
2014-08-28 09:38:32,381 : INFO : command: cwd: /builds/buildbot/pmoore/staging/staging
2014-08-28 09:38:32,381 : INFO : command: output:
Buildbot version: 0.8.2-hg-6627b2bfc144-default
Twisted version: 10.1.0
2014-08-28 09:38:32,568 : INFO : command: END (0.19s elapsed)

2014-08-28 09:38:33,635 : INFO : Comparing fennec mozconfigs to nightly mozconfigs...
2014-08-28 09:38:39,889 : ERROR : found in mobile/android/config/mozconfigs/android-armv6/release but not in mobile/android/config/mozconfigs/android-armv6/nightly: ac_add_options --enable-updater


This can be seen by comparing:
http://hg.mozilla.org/releases/mozilla-esr31/raw-file/default/mobile/android/config/mozconfigs/android-armv6/nightly
with:
http://hg.mozilla.org/releases/mozilla-esr31/raw-file/default/mobile/android/config/mozconfigs/android-armv6/release

This needs to either be a whitelisted difference, or resolved to be the same in both release and nightly in-tree, prior to first release of fennec for armv6 from esr31 branch.

Comment 1

[[e-mail] (:bhearsum)]

Sounds like --enable-update should be in the release mozconfig too, since we want to have single-locale updates through AUS. Does that sound right to you, Mark?

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

I don't think we care about single locale updates for this build. We want to support legacy Play Store users into the new year. We want to do this with as few resources as possible.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Ben Hearsum [:bhearsum] from comment #1)
> Sounds like --enable-update should be in the release mozconfig too, since we
> want to have single-locale updates through AUS. Does that sound right to
> you, Mark?

Like Kevin said, these armv6 builds are Release only and will only be served through the Play Store, which handles the updates for us. We but plan to make any Nightly builds of the armv6 esr. Is that different than other esr builds?

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> (In reply to Ben Hearsum [:bhearsum] from comment #1)
> > Sounds like --enable-update should be in the release mozconfig too, since we
> > want to have single-locale updates through AUS. Does that sound right to
> > you, Mark?
> 
> Like Kevin said, these armv6 builds are Release only and will only be served
> through the Play Store, which handles the updates for us. We but plan to
> make any Nightly builds of the armv6 esr. Is that different than other esr
> builds?

Those use the "nightly" mozconfig. In this case, we need to add --enable-update to the whitelist to shut release sanity up. Pete, that's located here: https://github.com/mozilla/build-tools/blob/master/buildbot-helpers/mozconfig_whitelist

Comment 5

[Pete Moore [:pmoore][:pete]]

Attachment: bug1059890_tools_v1.patch

As per Ben's comment above.

Please note, here is the diff of before vs after this patch:

                              'mk_add_options MOZ_PGO=1',
                              'export BUILDING_RELEASE=1']},
  'mozilla-esr31': {'android': ['ac_add_options --enable-official-branding',
                                'mk_add_options MOZ_PGO=1',
                                'export BUILDING_RELEASE=1'],
                    'android-armv6': ['ac_add_options --enable-official-branding',
                                      'mk_add_options MOZ_PGO=1',
-                                     'export BUILDING_RELEASE=1'],
+                                     'export BUILDING_RELEASE=1',
+                                     'ac_add_options --enable-updater'],
                    'android-x86': ['ac_add_options --enable-official-branding',
                                    'mk_add_options MOZ_PGO=1',
                                    'export BUILDING_RELEASE=1'],
                    'linux': ['ac_add_options --enable-official-branding',
                              'mk_add_options MOZ_PGO=1',
                              'export BUILDING_RELEASE=1'],
                    'linux64': ['ac_add_options --enable-official-branding',

This patch just touches the whitelist exceptions for mozilla-esr31, for android armv6 only - which is the branch and platform we specifically wish to target.

Comment 6

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8484892 [details] [diff] [review]
bug1059890_tools_v1.patch

Thanks Simone!

Landed: https://hg.mozilla.org/build/tools/rev/fa7da7cbad85

Comment 7

[Pete Moore [:pmoore][:pete]]

Manually updated buildbot-master81.srv.releng.scl3.mozilla.com:/builds/releaserunner/tools