Closed Bug 1059934 Opened 10 years ago Closed 10 years ago

lightweight themes selection panel doesn't contract to fit smaller list

Categories

(Firefox :: Toolbars and Customization, defect)

x86
macOS
defect
Not set
normal
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 35
Iteration:
35.3
Tracking Status
firefox34 --- affected
firefox35 --- verified

People

(Reporter: madhava, Assigned: Gijs)

References

Details

Attachments

(1 file)

screenshot: http://cl.ly/image/2X162I0S020j

Steps:
- install a few recommended themes by clicking on them
- install a another theme or two from the web
- go into the addons manager and remove some of them
- open this panel again
Flags: qe-verify?
Flags: qe-verify? → qe-verify+
Points: --- → 3
Blocks: 1007336
Marco, can you add this one, too? Thanks!
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 35.3
Flags: needinfo?(mmucci)
Added to IT 35.3
Flags: needinfo?(mmucci)
The panel code seems to be setting the height attribute. Removing it onpopuphidden fixes this malarky.
Attachment #8500331 - Flags: review?(jaws)
Comment on attachment 8500331 [details] [diff] [review]
lwt panel height shouldn't persist,

Review of attachment 8500331 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/CustomizeMode.jsm
@@ +1381,5 @@
>               element.previousSibling.localName == "toolbarbutton") {
>          element.previousSibling.remove();
>        }
>      }
> +    aEvent.target.removeAttribute("height");

I think the height gets set from the panel fade-in code. I wonder why this doesn't happen for other panels?
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> Comment on attachment 8500331 [details] [diff] [review]
> lwt panel height shouldn't persist,
> 
> Review of attachment 8500331 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/components/customizableui/CustomizeMode.jsm
> @@ +1381,5 @@
> >               element.previousSibling.localName == "toolbarbutton") {
> >          element.previousSibling.remove();
> >        }
> >      }
> > +    aEvent.target.removeAttribute("height");
> 
> I think the height gets set from the panel fade-in code. I wonder why this
> doesn't happen for other panels?

We remove all the standalone panels, and deal with it for PanelUI because we change the height attribute ourselves. Outside that (bookmarks, downloads) I am not sure.
Flags: needinfo?(enndeakin)
Comment on attachment 8500331 [details] [diff] [review]
lwt panel height shouldn't persist,

So I'd say that this patch is good for a low-risk uplift for Fx34, but it'd be nice to figure out the root cause and have a fix that will work for other panels as well (Fx35+).
Attachment #8500331 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/4b203cdd7d7d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
The original issue reproduced intermittently for me, but managed to get a scenario to consistently reproduce it on Nightly from 2014-08-28 and latest 34 Aurora, on Mac OS X 10.9.5 Macbook.

The scenario to reproduce this every time was:
1. Start Firefox with clean profile, then maximize it to full screen.
2. Leave only the first tab, then click on the "hamburger" menu and click on "Customize".
3. Click on "Theme", and click on 3 of the Recommended themes to add them.
4. Click on "Theme", and then on "Get More Themes".
5. Add 2 more themes, then return to the "Customize Nightly" tab.
6. Click on "Theme", and then on "Manage".
7. Remove all themes other than the active one and the default one.
8. Click on Extensions, then quickly back on Appearance (only the default and the active theme should be left in the list), then quickly switch to the "Customize Nightly" tab and click on "Theme".

With this scenario I always got the issue to show. Also, with the same scenario I could not get the issue to show on 3 attempts with latest 35 Nightly (BuildID=20141009030201).
Status: RESOLVED → VERIFIED
QA Contact: florin.mezei
Flags: needinfo?(enndeakin)
You need to log in before you can comment on or make changes to this bug.