1059974 - [Email] Email with long address is not word wrapped on the browse to URL overlay screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[John Thomas [:Johnt]]

Attachment: logcat_20140828_1125.txt

Description:
When the user receives an email with a very long address the address is truncated on the URL overlay screen. 

Repro Steps:
1) Update a Flame to 20140827040203
2) Set up an Email account on device.
3) Send an email with a very long address to the email that is set up on device.
4) Open up received email.

Actual:
Long email address that was received is truncated.

Expected:
It is expected that the long email address will be word wrapped.

Environmental Variables:
Device: Flame Master (319mb)
Build ID: 20140827040203
Gaia: 6e804a42ab90f4251c7fe8c68731dc1c6abd8006
Gecko: 0753f7b93ab7
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/8744/
See attached: Screenshot, logcat.

Comment 1

[John Thomas [:Johnt]]

Attachment: Truncated Email Address

Comment 2

[John Thomas [:Johnt]]

This issue also reproduces on the Flame 2.1 (512mb), Open_C 2.1, Flame 2.0 (319mb), Flame 2.0      (319mb), Open_C 2.0, Flame 1.4 and Open_C 1.4

Result: When the user receives an email with a very long address the address is truncated on the URL overlay screen. 

Environmental Variables:
Device: Flame Master (512mb)
Build ID: 20140827040203
Gaia: 6e804a42ab90f4251c7fe8c68731dc1c6abd8006
Gecko: 0753f7b93ab7
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Open_C Master
Build ID: 20140827040203
Gaia: 6e804a42ab90f4251c7fe8c68731dc1c6abd8006
Gecko: 0753f7b93ab7
Version: 34.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Flame 2.0 (319mb)
Build ID: 20140827000204
Gaia: d72f8ad53448aed577c01ff6e11d958463f261e7
Gecko: 2a18149b3ae8
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Open_C 2.0
Build ID: 20140827000204
Gaia: d72f8ad53448aed577c01ff6e11d958463f261e7
Gecko: 2a18149b3ae8
Version: 32.0 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Flame 1.4 (319mb)
Build ID: 20140827003002
Gaia: 05653cb12d324649687dad3eeb2ea373a2ad84d4
Gecko: 7ad0648b8447
Version: 30.0 (1.4)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Environmental Variables:
Device: Open_C 1.4
Build ID: 20140827003002
Gaia: 05653cb12d324649687dad3eeb2ea373a2ad84d4
Gecko: 7ad0648b8447
Version: 30.0 (1.4)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 3

[James Burke [:jrburke]]

Attachment: address-info.png

I believe this is working as designed, this was a conscious choice given the reasoning below, but flagging UX for confirmation:

On the message reader screen, the email addresses are kept to one line truncated with ... to avoid them eating up the whole display. Also, if we have a name associated with that address, that name is shown there, not the email address. So the message reader screenshot attached to here looks correct. It cannot be used to verify the whole address, particularly when showing a person name.

However, to see the full email address for verification purposes, tap on the contact bubble, and it will bring up the contact menu screen, as shown in this attachment.

The email address shown at the top uses a marquee-type side animation scroll to show the full address. This capture was taken mid-scroll, which is why it is just showing the middle of the address.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Test case was talking about the body of the email not the To: field. The tester misunderstood the test case but I'll wait for UX to comment on this before closing as invalid.

Comment 5

[Juwei Huang[:juwei]]

Attachment: Word-wrap-email-text.png

James you're right, if it's talking about email address at the "To" field, we do use "..." for a long address.

Yet I think this bug is more talking about a email link in message body can be truncated so that users cannot access the correct link.

I test on my flame, please check the attachment.
It looks fine on screen A, so I'm not sure it's because there are too much "@" in the test case or it's a bug. 

Also, when I try to type a long email address on the compose view, I found that I can type text endlessly without word wrap. (Please see screen B & C).
It makes the text hard to read since we cannot scroll back to the left side, and it also breaks the screen into half gray half white view.

I think we should word wrap the text on both input field and message body so that users can read what they type. And indeed the email address in message body should be read as a whole rather than break out.

Comment 6

[Paco Rampas [:paco]]

Attachment: patch in github

Here a patch for fixing it. I don't know to who I should ask review.

Comment 7

[Paco Rampas [:paco]]

Attachment: email_long_email.png

Here I attach the screenshot. There isn't x scroll with longs emails.

Comment 8

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8482180 [details]
email_long_email.png

Flipping review to James (he's the email frontend owner).

Comment 9

[James Burke [:jrburke]]

I should have left a comment on this sooner, but I have been stuck on some high priority work for bug 1059100 and then possibly an uplift branch for bug 915643, then I should be clear to do a review. I am hopeful it can happen later this week. I really apologize for letting a review request wait this long.

Comment 10

[Paco Rampas [:paco]]

> I really apologize for letting a review request wait
> this long.

Don't worry and thanks for letting me know.

Comment 11

[Juwei Huang[:juwei]]

Hi Paco, the patch looks good to me, thank you!
Waiting for James' review.

Comment 12

[James Burke [:jrburke]]

Comment on attachment 8482176 [details] [review]
patch in github

Looks good, tried on device and on desktop. Thank you, sorry the review turnaround time was so bad.

Comment 13

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/3704381a640bfc8f0ce3eb39404ebbf67e533438

from pull request:
https://github.com/mozilla-b2g/gaia/pull/23560

Comment 14

[Edward Chen[:edchen]]

[Environment]
Gaia      944e5b4582c4efa1b67cd33245dbb8f6aa25d09f
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/7546fedad918
BuildID   20140914160203
Version   34.0a2
ro.build.date   Fri Jun 27 15:57:58 CST 2014
ro.bootloader   L1TC00011230
ro.build.version.incremental   110

[Result]
PASS

Comment 16

[James Burke [:jrburke]]

While this is fixed on master, it is not fixed on 2.1, which is what is implied by the "Version: 34.0a2" in comment 14's environment info. Bug 1067261 was filed for this bug on 2.1, but was duped to this bug. If desired for 2.1, this bug should track any uplift.