1059980 - Logviewer: Dynamic scroll in failed steps not intuitive with particular workflow

Status: RESOLVED DUPLICATE of bug 1315808

(Tree Management :: Treeherder, defect, P4)

Description

[Jonathan French (:jfrench)]

The dynamic scroll to point, doesn't appear as intuitive as it could be, with failed steps.

This is pretty minor and appears to have been around awhile (ie. it is on production) - and is unrelated to our recent work landed today in dev/stage to make the log viewer collapse/flow at smaller browser widths. So that is good news.

To reproduce
o open this b2g failed job structured log as an example
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=387923&repo=b2g-inbound
o click in sequence, _directly_ on each the 4 failure lines in the log steps (786, 798, 857, 869) - or the adjacent little grey line number box
o so far so good, the loadMore() log scroll stops at the desired red-box failure lines
o now - click back on 786

Expected behavior
You are scrolled to line 786 (red box)

Observed behavior
You are scrolled to line 733

This appears to be because the scroll is sending you to the 'parent' Jetpack Warnings line higher up, when you click on either of the failed log step containers >1 time. On a first click loading the page.. it sends you correctly to the failed line... on these >1 clicks, you instead get sent to the first line in the log step.

I would expect to navigate to the log line every time in the above workflow, unless I specifically clicked on that orange/brown header part of the log step where the Jetpack text is.

I can reproduce it on Chrome and Firefox, at least on Windows. Hopefully others can also.

Workaround
Click twice, once to place focus in that failed log step, once to re-select the failure line desired.

Comment 1

[Ed Morley [:emorley]]

Yeah agree that's what I'd expect too; not sure how often this will come up (I do jump around failures on TBPL sometimes) - guess we'll just have to see, and can bump priority more if needed :-)

Comment 2

[Jonathan French (:jfrench)]

I retested this in current production, it's still valid. There are three clicks required, one to make the other orange failure step (and chunk) load, one I think which focus into the interior step area, and yet another click to scroll to the line.

The desired behavior would be one click; which if on the new failed-step 'error line container', would both load the needed chunk and scroll to the line.

https://github.com/mozilla/treeherder/blob/master/ui/partials/logviewer/lvLogSteps.html#L4
https://github.com/mozilla/treeherder/blob/master/ui/partials/logviewer/lvLogSteps.html#L26

Comment 3

[Ed Morley [:emorley]]

I think this should be fixed by bug 1315808.