1059995 - Have marionette match error codes from w3c spec

Status: RESOLVED WORKSFORME

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

we currently don't match all the errors here: https://dvcs.w3.org/hg/webdriver/raw-file/tip/webdriver-spec.html#status-codes like 'unsupported operation'.

Comment 1

[Robert Wood [:rwood]]

The following error codes are missing:

invalid argument
invalid sessionid
session not created
unsupported operation

Referring to this link:

https://selenium.googlecode.com/git/docs/api/py/webdriver_remote/selenium.webdriver.remote.errorhandler.html

'unsupported operation' = METHOD_NOT_ALLOWED (405)

However the other errors mentioned above are not in the list. What should I use for the actual error code values? Is there another doc somewhere that I am missing?

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

(In reply to Robert Wood [:rwood] from comment #1)
> The following error codes are missing:
> 
> invalid argument
> invalid sessionid
> session not created
> unsupported operation
> 
> Referring to this link:
> 
> https://selenium.googlecode.com/git/docs/api/py/webdriver_remote/selenium.
> webdriver.remote.errorhandler.html
> 
> 'unsupported operation' = METHOD_NOT_ALLOWED (405)
> 
> However the other errors mentioned above are not in the list. What should I
> use for the actual error code values? Is there another doc somewhere that I
> am missing?

Not sure if we should be following selenium's guide. This is more of a placeholder until webdriver defines the exact error codes. Perhaps David can tell us more about the error codes.

Comment 3

[David Burns :automatedtester]

Error codes are no more! Long live Error Codes!

In one of the earlier W3C meetings Hixie recommended that we don't use Error codes and use Error messages. I am happy for you to add the error codes (of your own choosing) because when https://bugzilla.mozilla.org/show_bug.cgi?id=945729 lands we will be ripping them out for the pure status message approach.

Comment 4

[Robert Wood [:rwood]]

Attachment: bug1059995.patch

Ok, thanks David

Comment 5

[David Burns :automatedtester]

Comment on attachment 8482724 [details] [diff] [review]
bug1059995.patch

Happy with the error codes but we should also handle them.

http://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/marionette.py#664 should be updated with conditionals to handle them so that future patches have the necessary pieces.

Comment 6

[Robert Wood [:rwood]]

(In reply to David Burns :automatedtester from comment #5)
> Comment on attachment 8482724 [details] [diff] [review]
> bug1059995.patch
> 
> Happy with the error codes but we should also handle them.
> 
> http://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/
> marionette/marionette.py#664 should be updated with conditionals to handle
> them so that future patches have the necessary pieces.

Ok thanks David. UNSUPPORTED_OPERATION will be added as part of bug 1045103 as it is required there. Will leave this bug open for the remaining error codes.

Comment 7

[Malini Das [:mdas] - Away, not checking bugmail]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1065933#c69, I'll move the conversation here. I prefer numbers to strings so there's less data to send over the wire, and less characters to compare when checking strings. It's not a strong preference though

Comment 8

[David Burns :automatedtester]

a lot of work has happened in this area so going to assume it doing the right thing currently