1060121 - Make WebGLContext::TexImage2D avoid readback for video elements on Windows

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Chiajung Hung [:chiajung]]

This is a follow up bug for bug 814524.

In bug 814524, we provided a shader for convert video frames in GPU and make things faster, however, the shader there do not work on Windows platform.

Comment 1

[Chiajung Hung [:chiajung]]

Attachment: V1

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8480946 [details] [diff] [review]
V1

Review of attachment 8480946 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLBlitHelper.cpp
@@ +182,5 @@
>  GLBlitHelper::InitTexQuadProgram(BlitType target)
>  {
>      const char kTexBlit_VertShaderSource[] = "\
> +        #ifdef GL_ES                                  \n\
> +            precision mediump float;                  \n\

Don't indent the contents of ifdefs, generally.

Comment 3

[Chiajung Hung [:chiajung]]

Comment on attachment 8480946 [details] [diff] [review]
V1

Review of attachment 8480946 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I will push to try later.

::: gfx/gl/GLBlitHelper.cpp
@@ +182,5 @@
>  GLBlitHelper::InitTexQuadProgram(BlitType target)
>  {
>      const char kTexBlit_VertShaderSource[] = "\
> +        #ifdef GL_ES                                  \n\
> +            precision mediump float;                  \n\

Other shaders in this file indent in this style. I just follow them.
Should I fix all the indent in this file?

Comment 4

[Chiajung Hung [:chiajung]]

By the way, I find some nit in the patch of Bug 814524. May I carry the fix here?

Comment 5

[Chiajung Hung [:chiajung]]

Attachment: V1, final

Add review info, carry r+.

Comment 6

[Chiajung Hung [:chiajung]]

Try ticket:
https://tbpl.mozilla.org/?tree=Try&rev=9cddac48f001

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7cd03cbdb5f

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e7cd03cbdb5f