Closed Bug 1060236 Opened 10 years ago Closed 10 years ago

Fix failure in test_cards_view_with_two_apps.py

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: viorela, Assigned: viorela)

Details

Attachments

(1 file)

Test test_cards_view_with_two_apps.py has failed in the latest master build: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame.mozilla-central.ui.functional.smoke/101/HTML_Report/
I suppose the changes are related to commit https://github.com/mozilla-b2g/gaia/commit/b34143e3b9edce351159eff495b5e41695ef861d. 
We should update and fix our test.

Traceback (most recent call last):
File "/var/jenkins/2/workspace/flame.mozilla-central.ui.functional.smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.8.3-py2.7.egg/marionette/marionette_test.py", line 171, in run
testMethod()
File "/var/jenkins/2/workspace/flame.mozilla-central.ui.functional.smoke/tests/python/gaia-ui-tests/gaiatest/tests/functional/cards_view/test_cards_view_with_two_apps.py", line 43, in test_that_app_can_be_launched_from_cards_view
cards_view.wait_for_card_ready(self._test_apps[0])
File "/var/jenkins/2/workspace/flame.mozilla-central.ui.functional.smoke/tests/python/gaia-ui-tests/gaiatest/apps/system/regions/cards_view.py", line 34, in wait_for_card_ready
self.wait_for_condition(lambda m: current_frame.size['width'] - card.size['width'] == 2 * card.location['x'])
File "/var/jenkins/2/workspace/flame.mozilla-central.ui.functional.smoke/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 54, in wait_for_condition
Wait(self.marionette, timeout).until(method, message=message)
File "/var/jenkins/2/workspace/flame.mozilla-central.ui.functional.smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.8.3-py2.7.egg/marionette/wait.py", line 143, in until
cause=last_exc)
TimeoutException: TimeoutException: Timed out after 30.0 seconds

Device firmware (date) 	28 Aug 2014 08:29:26
Device firmware (incremental) 	eng.cltbld.20140828.112916
Device firmware (release) 	4.3
Device identifier 	flame
Gaia date 	28 Aug 2014 08:45:33
Gaia revision 	007f3c50cf69
Gecko build 	20140828160238
Gecko revision 	d697d649c765
Gecko version 	34.0a1
Attachment #8481115 - Flags: review?(zcampbell)
Attachment #8481115 - Flags: review?(robert.chira)
Attachment #8481115 - Flags: review?(florin.strugariu)
Attachment #8481115 - Flags: review?(florin.strugariu) → review+
Attachment #8481115 - Flags: review?(robert.chira) → review-
Comment on attachment 8481115 [details] [review]
Github PR:https://github.com/mozilla-b2g/gaia/pull/23459

r-, as Robert noted, keep the naming of variables matching the flick method.
Attachment #8481115 - Flags: review?(zcampbell) → review-
Assignee: nobody → viorela.ioia
Attachment #8481115 - Flags: review?(zcampbell)
Attachment #8481115 - Flags: review?(robert.chira)
Attachment #8481115 - Flags: review-
Comment on attachment 8481115 [details] [review]
Github PR:https://github.com/mozilla-b2g/gaia/pull/23459

r+!
Attachment #8481115 - Flags: review?(zcampbell)
Attachment #8481115 - Flags: review?(robert.chira)
Attachment #8481115 - Flags: review+
Merged:
https://github.com/mozilla-b2g/gaia/commit/19e22f986fbbde689dee517a5ec29b096074bc5e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: