1060250 - [Stingray] Implement DLNA browsing/playing app in Gaia dev_app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

See Bug #984108.
We are going to implement a DLNA app which contains features below:

* Discover uPnP servers around
* Connect ContentDirectory service on media server
* Folder-like browsing on media server
* Stream and play media file (if supported by browser)
* Able to send play, pause, stop, seek ahead/behind commands
  (which belong to AVTransport service) to media renderer.

This app should make use of UDPSocket implemented in bug 745283
to make uPnP requests, and land on gaia dev_apps directory.
Currently this app aims for validating functional working, debugging
of UDPSocket; and also for demo purpose.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: 23473.html

I spilt it into 3 commits, with two of them are independent libraries (plug.play.js and ssdp.js) needed for making uPnP requests; and the last one as the main part of the app.

Evelyn and SC would you help review this new dev_app?

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8481229 [details]
23473.html

f+ with some comments. BTW, this app imports https://github.com/richtr/plug.play.js (which uses Apache v2.0 license) and we need to make sure to follow the copyright statement.

Comment 3

[Evelyn Hung]

Comment on attachment 8481229 [details]
23473.html

Hi Rex,

I didn't look closely but SC has left a few good comments on Github. Please address them and rebase your patch. 

For the library using Apache v2.0 license, You also need to follow its redistribution rule (https://www.apache.org/licenses/LICENSE-2.0.html#redistribution) to put a NOTICE file under your app folder.

Flag me review again for a final check, Thanks!

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Patch

This is a modified Patch carrying feedback+ from SC.

1. Added some changelog on Plug.Play.js to meet apache 2.0 license.
2. Handle sever online/offline event correctly

For 2. above, we found it's not possible to receive SSDP notification packages
on our phone at _OS level_, therefore server online/offline event is never 
received. We may need a follow-up bug and find Gonk team's help. For now this
 feature is tested to run correctly via embedding app codes into Firefox Addon on PC (Thanks to SC's help).

Evelyn are you available for reviewing this patch? I guess we just need to review 
the 4th commit.

Comment 5

[Evelyn Hung]

Comment on attachment 8527590 [details] [review]
Patch

Hi Rex, I'm thinking moving this app to tv_apps/, what do you think?

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

It's ok for me, but the current UI is not made for wide-screen TV. We can move it and open a follow-bug for that anyway.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

And if we commit it into tv_apps I may need to squash all the changes. so It'll become a big commit with about 40 file changes.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

https://github.com/mozilla-b2g/gaia/commit/ed25b3b0e66a0e13b4d0d45f54911dd5475bf660