1060302 - Error summary: Display a message instead of a blank panel if log parser found nothing

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

At the moment, if a job failed but the log parser did not match against any error lines, in TBPL we get:
"Summary is empty."

In treeherder the Failure Summary is just empty.

In the future perhaps we can come up with some better fallback if the log parser didn't match anything (eg reporting in which job step the run failed, using the result codes) - however as a simple fix for now let's just display a message.

I'm guessing we just add an ng-if against 'suggestions', as a fallback near here:
https://github.com/mozilla/treeherder-ui/blob/19afb49efb42f0f352f074f12379d01eb949e83e/webapp/app/plugins/failure_summary/main.html#L4

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Just checking for "suggestions.length == 0" results in "Summary empty" being seen under the spinner whilst the summary is still loading, so this waits for loading to stop.

Not sure if this is the best way to do this, or if you'd prefer a specific summary_empty variable on the controller side.

Comment 2

[Ed Morley [:emorley]]

Jonathan/Cameron, would either of you mind taking the review for this? (Didn't realise Mauro was away)

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8481233 [details] [diff] [review]
Patch v1

(See comment 1)

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8481233 [details] [diff] [review]
Patch v1

Review of attachment 8481233 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  Not sure we need the ending period, but I don't have a strong opinion about it.

Comment 5

[Ed Morley [:emorley]]

Agree about the trailing period, have removed it.

https://github.com/mozilla/treeherder-ui/commit/d467a037cbada04bdb08ff36ba7c7321536c2bdc

I'm also wondering if something like "No log failure lines recognised" would be more descriptive of the actual problem - but we can save that for another time - least we have something displayed now :-)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/cc93bef967622e819072336646d55005f58c8f74
Bug 1060302 - Display a message if the failure summary was empty