1060310 - mozharness configuration is writable in query_abs_dir()

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Massimo Gervasini [:massimo]]

In BaseScript.__init__, we call query_abs_dis() before locking the configuration (_pre_config_lock), so in query_abs_dir(), the configuration is still writable. 

http://hg.mozilla.org/build/mozharness/file/461eb9ef2e34/mozharness/base/script.py#l1328

Comment 1

[Massimo Gervasini [:massimo]]

Attachment: [mozharness] Bug 1060310 - lock configuration before calling abs_query_dirs().patch

removed call to query_abs_dirs() in new_log_obj

Comment 2

[Jordan Lund (:jlund)]

Comment on attachment 8481235 [details] [diff] [review]
[mozharness] Bug 1060310 - lock configuration before calling abs_query_dirs().patch

Review of attachment 8481235 [details] [diff] [review]:
-----------------------------------------------------------------

we discussed this earlier. I think this is the right thing to do. The downside is we define this in two places now. Although I think we have only ever used it in base_work_dir and it's still configurable within base_work_dir via c['log_dir'].

This would be a big mess if we landed this and missed something. Think we should trigger a job or two within cypress and then confirm that the logs are uploaded and the log_dir is where its  supposed to be on the respective slave?