Note: There are a few cases of duplicates in user autocompletion which are being worked on.

mozharness configuration is writable in query_abs_dir()

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: massimo, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
In BaseScript.__init__, we call query_abs_dis() before locking the configuration (_pre_config_lock), so in query_abs_dir(), the configuration is still writable. 

http://hg.mozilla.org/build/mozharness/file/461eb9ef2e34/mozharness/base/script.py#l1328
(Reporter)

Updated

3 years ago
Blocks: 740142
(Reporter)

Comment 1

3 years ago
Created attachment 8481235 [details] [diff] [review]
[mozharness] Bug 1060310 - lock configuration before calling abs_query_dirs().patch

removed call to query_abs_dirs() in new_log_obj
Attachment #8481235 - Flags: review?(jlund)
Comment on attachment 8481235 [details] [diff] [review]
[mozharness] Bug 1060310 - lock configuration before calling abs_query_dirs().patch

Review of attachment 8481235 [details] [diff] [review]:
-----------------------------------------------------------------

we discussed this earlier. I think this is the right thing to do. The downside is we define this in two places now. Although I think we have only ever used it in base_work_dir and it's still configurable within base_work_dir via c['log_dir'].

This would be a big mess if we landed this and missed something. Think we should trigger a job or two within cypress and then confirm that the logs are uploaded and the log_dir is where its  supposed to be on the respective slave?
Attachment #8481235 - Flags: review?(jlund) → review+
(Reporter)

Updated

3 years ago
Attachment #8481235 - Flags: checked-in+
(Reporter)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.