1060328 - Failure summary: No summary is shown for "retry" and "usercancel" jobs

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

On TBPL we can still see the summary for jobs that failed with a result of "retry" or "usercancel". 

In treeherder we exclude them:

        var failure_results = ["busted", "exception", "testfailed"];
...
            // retrieve bug suggestions only if the job has failures
            if(angular.isDefined(newValue) &&
                    failure_results.indexOf($scope.job.result) !== -1){

In addition, with TBPL we've wanted to be able to show the summaries more easily for successful jobs too (we've just not been parsing those logs, so this wasn't possible) - so let's just get rid of the check and show for all job result types (this will let us see parser false positives more easily, presuming we still parse successful logs for failure lines).

Comment 1

[Ed Morley [:emorley]]

Attachment: Retrieve the failure summary for all job result types

Prior to this patch the failure summary was not shown for "retry", "usercancel", "skipped" (unused), or "success". 
Note: The summary will still be empty for "success" due to bug 1060339.

Comment 2

[Ed Morley [:emorley]]

Jonathan/Cameron, would either of you mind taking the review for this? (Didn't realise Mauro was away)

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 8481277 [details] [diff] [review]
Retrieve the failure summary for all job result types

Review of attachment 8481277 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.  As stated, this won't affect the server-side log parsing.  Only what can be shown in the UI.  So no logparser load increase.

Comment 4

[Ed Morley [:emorley]]

Thanks :-)

https://github.com/mozilla/treeherder-ui/commit/cea705036dcb5f9dd2dcd0974afa8080f97d42e2

Comment 5

[Mauro Doglio [:mdoglio]]

Comment on attachment 8481277 [details] [diff] [review]
Retrieve the failure summary for all job result types

Review of attachment 8481277 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d87e5494d54259a1f46db81b950157e008cb4c93
Bug 1060328 - Retrieve the failure summary for all job result types

Prior to this patch the failure summary was not shown for "retry",
"usercancel", "skipped" (unused), or "success". Note: The summary
will still be empty for "success" due to bug 1060339.