[shared/pages/import] Implement gaia-header

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wilsonpage, Assigned: wilsonpage)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The shared/pages/import app needs to migrate from deprecated header building-block to gaia-header web-component.
(Assignee)

Comment 1

4 years ago
Created attachment 8481324 [details] [review]
pull-request (master)
Attachment #8481324 - Flags: review?(francisco)
(Assignee)

Comment 2

4 years ago
francisco: I haven't had chance to test this patch on device as I wasn't sure how to launch it. It's a pretty simple patch though.
(Assignee)

Updated

4 years ago
Blocks: 1005830

Comment 3

4 years ago
Thank you, Wilson. If we can get review on this on Monday (a holiday in U.S. and Canada) it should still be able to make FL.
https://github.com/mozilla-b2g/gaia/commit/b98e39c32a7049dd8054b34bff9edb14b215267d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8481324 [details] [review]
pull-request (master)

Not happy with the way this has been merged, no review, with gaia-try totally busted.

But ... at least the code looks good to me.

Thanks folks for the work here.
Attachment #8481324 - Flags: review?(francisco)
You need to log in before you can comment on or make changes to this bug.