1060386 - Mobile Client needs to report the number of shared URLs on FxOS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

As a product manager I want to know daily the number of shared URLs on FxOS  client so that I know how often users try to communicate via this fall-back process.

When we say "shared" in Loop Mobile Client, it means only URLs sent via e-mail or SMS.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: WIP

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/120/files

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Example report

This is an example of the reports that we are currently sending with the attached patch. I was able to test it locally running the telemetry server and I can see that the reports are being successfully logged.

Comment 4

[Mark Reid [:mreid]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #3)
> Created attachment 8494642 [details]
> Example report
> 
> This is an example of the reports that we are currently sending with the
> attached patch. I was able to test it locally running the telemetry server
> and I can see that the reports are being successfully logged.

It looks like you've used the "envelope" format that Telemetry uses to store payloads locally before uploading to the server.  The actual body of the submitted payload should only include the part inside the "payload" key.

Please also make the following changes:
- Add an "appName":"FirefoxOS" to the "info" part of the payload
- Remove the "submission_date" key (this is calculated server-side) 

Consider using "37e9e79" as the appBuildID (instead of a separate "loop_version" field). That will give you the ability to filter the submissions by this field when doing data analyses. If this value is highly volatile and unlikely to contain many submissions per version, it would be better to leave it as-is.

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8494636 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/120/files

LGTM. r=me

Please, do the naming of files and object as we agreed and have a look at a couple of comments I left con the PR. Thanks for taking care of it!

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Example report

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Mark Reid [:mreid] from comment #4)
> (In reply to Fernando Jiménez Moreno [:ferjm] from comment #3)
> > Created attachment 8494642 [details]
> > Example report
> > 
> > This is an example of the reports that we are currently sending with the
> > attached patch. I was able to test it locally running the telemetry server
> > and I can see that the reports are being successfully logged.
> 
> It looks like you've used the "envelope" format that Telemetry uses to store
> payloads locally before uploading to the server.  The actual body of the
> submitted payload should only include the part inside the "payload" key.
> 
> Please also make the following changes:
> - Add an "appName":"FirefoxOS" to the "info" part of the payload
> - Remove the "submission_date" key (this is calculated server-side) 
> 
> Consider using "37e9e79" as the appBuildID (instead of a separate
> "loop_version" field). That will give you the ability to filter the
> submissions by this field when doing data analyses. If this value is highly
> volatile and unlikely to contain many submissions per version, it would be
> better to leave it as-is.

Thanks for the feedback Mark! I made the changes that you suggested and attached an updated example report. Please, let us know if any other change is required.

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/2d1f1b7b9974f572c0194f2d1d9a683544ac541c